Commit `349bec0e99`

349bec0e99f330fc1172ca9847c58f019e861f61

parent: eb8a0d30da

Unsigned

cmc <hello@cleberg.net> · 2026-07-20 23:29 UTC

fix(a11y): suppress disabled-control contrast findings on the rule

WCAG 1.4.3 exempts inactive components from contrast requirements, so
Inspect's Run button — disabled until a domain is typed — was reporting a
contrast failure that was never a real defect.

The first attempt typed a domain to enable the button. That worked for
the single-screen test but raised the keyboard, which then followed the
audit onto every later screen in the Dynamic Type sweep and reported nine
phantom hit-region findings per screen against the system emoji picker's
category buttons. Suppressing on the rule instead — drop contrast
findings whose element reports isEnabled == false — fixes it everywhere
with no UI manipulation.

Also documents that simulator keyboard state persists across runs, so a
dirty simulator inflates the burndown with system-UI findings. Erase and
re-run before believing anything that names system UI.

Layout: unified · split

Docs/ACCESSIBILITY.md +13 −6

 ## Notes
-- **Disabled controls are a false positive.** WCAG 1.4.3 exempts inactive
+- **Disabled controls are a false positive, and are suppressed.** WCAG 1.4.3
-  components from contrast requirements, but the audit flags them anyway. The
+  exempts inactive components from contrast requirements, but the audit flags
-  Inspect screen's Run button is disabled until a domain is typed, and auditing
+  them anyway — Inspect's Run button is disabled until a domain is typed, and
-  the empty state reported a contrast failure that was never a real defect —
+  auditing the empty state reported a contrast failure that was never a real
-  which is why `testInspectScreen` types a domain before auditing. Watch for
+  defect. The harness now drops contrast findings whose element reports
-  this before "fixing" a contrast finding on a disabled control.
+  `isEnabled == false`. Suppressing on the rule beats driving the UI to enable
+  the control: typing raises the keyboard, which then follows the audit onto
+  later screens and flags the system emoji picker's category buttons.
+- **A dirty simulator inflates the burndown.** Keyboard state persists across
+  runs, so a simulator left with the emoji picker open reports ~9 phantom
+  hit-region findings per screen. If findings appear that name system UI
+  ("Flags category", "Frequently Used category"), erase the simulator
+  (`xcrun simctl erase <udid>`) and re-run before believing them.
 - Audits retry up to three times. Slower machines can miss the audit's internal
   deadline (`Audit failed to complete in time`, code `-56`), which is a tooling
   timeout, not an app defect. A screen that still cannot be audited is reported

DomainDigUITests/AccessibilityAuditHarness.swift +12

	@@ -85,6 +85,18 @@ enum AccessibilityAuditHarness {
85	timeout = nil	85	timeout = nil
86	do {	86	do {
87	try app.performAccessibilityAudit { issue in	87	try app.performAccessibilityAudit { issue in
		88	// WCAG 1.4.3 exempts inactive components from contrast
		89	// requirements, but the audit flags them anyway. Inspect's
		90	// Run button is disabled until a domain is typed, so the
		91	// empty state reported a contrast failure that was never a
		92	// real defect. Suppressing on the rule beats driving the UI
		93	// to enable the control: typing raises the keyboard, which
		94	// then follows the audit onto later screens and flags the
		95	// system emoji picker's category buttons.
		96	if issue.auditType.contains(.contrast), issue.element?.isEnabled == false {
		97	return true
		98	}
		99
88	let isEnforced = !enforcedAuditTypes.intersection(issue.auditType).isEmpty	100	let isEnforced = !enforcedAuditTypes.intersection(issue.auditType).isEmpty
89	let marker = isEnforced ? "FAIL" : "report"	101	let marker = isEnforced ? "FAIL" : "report"
90	// Include the element so the burndown says what to fix, not	102	// Include the element so the burndown says what to fix, not

DomainDigUITests/AccessibilityAuditTests.swift +1 −14

	@@ -17,20 +17,7 @@ final class AccessibilityAuditTests: XCTestCase {
17	// MARK: Per-screen audits	17	// MARK: Per-screen audits
18		18
19	func testInspectScreen() throws {	19	func testInspectScreen() throws {
20	let app = AccessibilityAuditHarness.launch()	20	try auditRootTab("Inspect")
21	app.selectRootTab("Inspect")
22
23	// Type a domain so the Run button is enabled. A disabled control has no
24	// contrast requirement under WCAG 1.4.3, but the audit still flags it,
25	// so auditing the empty state would report a false positive forever.
26	let field = app.textFields.firstMatch
27	if field.waitForExistence(timeout: 5) {
28	field.tap()
29	field.typeText("example.com")
30	}
31
32	let audited = try AccessibilityAuditHarness.audit(app, screen: "inspect", test: self)
33	try XCTSkipUnless(audited, "Audit did not complete in time for Inspect")
34	}	21	}
35		22
36	func testDashboardScreen() throws {	23	func testDashboardScreen() throws {

Commit 349bec0e99

Commit `349bec0e99`