Commit `104dd73fbc`

104dd73fbc82a9d57eb4681ec7f7b43313d24e67

parent: ebe0e42d13

Unsigned

cmc <hello@cleberg.net> · 2026-09-07 21:36 UTC

Deployment target 18.0 (!84)

The app compiled clean at 18.0 with no code change; 26.5 was the new-project default. Both packages accept iOS 16.

Verified on a downloaded iOS 18.6 runtime (iPhone 16) and on 26.5: unit suite green on both; all 14 live smoke tests green on both. Two things surfaced only on 18: tests that built their own decoder with .iso8601 failed on fractional seconds, so they now use GitbayClient.decoder(); and list section headers render uppercased, so the suite matches them ignoring case. The suite also signs in at setup when a device starts on the token screen.

Layout: unified · split

README.org +1 −1

	@@ -46,7 +46,7 @@ Any gitbay instance works. You just need to enter the host at sign-in.
46		46
47	* Building	47	* Building
48		48
49	Requires Xcode with an iOS 26.5 SDK. Swift 6 language mode, default =MainActor=	49	Builds with the iOS 26.5 SDK and runs on iOS 18.0 and later. Swift 6 language mode, default =MainActor=
50	isolation.	50	isolation.
51		51
52	#+begin_src sh	52	#+begin_src sh

gitbay.xcodeproj/project.pbxproj +4 −2

 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 26.5;
+				IPHONEOS_DEPLOYMENT_TARGET = 18.0;
 				LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
 				MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
 				MTL_FAST_MATH = YES;
 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 26.5;
+				IPHONEOS_DEPLOYMENT_TARGET = 18.0;
 				LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
 				MTL_ENABLE_DEBUG_INFO = NO;
 				MTL_FAST_MATH = YES;
 				DEVELOPMENT_TEAM = ZCNAX3VL9D;
 				ENABLE_PREVIEWS = YES;
 				GENERATE_INFOPLIST_FILE = YES;
+				INFOPLIST_KEY_CFBundleDisplayName = gitbay;
 				INFOPLIST_KEY_ITSAppUsesNonExemptEncryption = NO;
 				INFOPLIST_KEY_LSApplicationCategoryType = "public.app-category.developer-tools";
 				INFOPLIST_KEY_UIApplicationSceneManifest_Generation = YES;
 				DEVELOPMENT_TEAM = ZCNAX3VL9D;
 				ENABLE_PREVIEWS = YES;
 				GENERATE_INFOPLIST_FILE = YES;
+				INFOPLIST_KEY_CFBundleDisplayName = gitbay;
 				INFOPLIST_KEY_ITSAppUsesNonExemptEncryption = NO;
 				INFOPLIST_KEY_LSApplicationCategoryType = "public.app-category.developer-tools";
 				INFOPLIST_KEY_UIApplicationSceneManifest_Generation = YES;

gitbay/Networking/GitbayClient.swift +4 −1

     /// Dates on the wire are RFC 3339, some with fractional seconds
     /// (SQLite's `%Y-%m-%dT%H:%M:%fZ` default), some without (`repo log`).
-    private static func decoder() -> JSONDecoder {
+    /// Internal so tests decode fixtures the way the client does: the
+    /// stock `.iso8601` strategy accepts fractional seconds on iOS 26 and
+    /// refuses them on iOS 18.
+    static func decoder() -> JSONDecoder {
         let decoder = JSONDecoder()
         decoder.dateDecodingStrategy = .custom { decoder in
             let text = try decoder.singleValueContainer().decode(String.self)

gitbayTests/BodyFormatTests.swift +2 −4

 struct BodyFormatDecodingTests {
     private func decodeIssue(_ json: String) throws -> IssueDetail {
-        let decoder = JSONDecoder()
+        let decoder = GitbayClient.decoder()
-        decoder.dateDecodingStrategy = .iso8601
         return try decoder.decode(IssueDetail.self, from: Data(json.utf8))
     }
     private func decodeMR(_ json: String) throws -> MRDetail {
-        let decoder = JSONDecoder()
+        let decoder = GitbayClient.decoder()
-        decoder.dateDecodingStrategy = .iso8601
         return try decoder.decode(MRDetail.self, from: Data(json.utf8))
     }

gitbayTests/DepsTests.swift +1 −2

	@@ -33,8 +33,7 @@ private let fullStatus = """
33	struct DepsDecodingTests {	33	struct DepsDecodingTests {
34		34
35	private func decode(_ json: String) throws -> DepsStatus {	35	private func decode(_ json: String) throws -> DepsStatus {
36	let decoder = JSONDecoder()	36	let decoder = GitbayClient.decoder()
37	decoder.dateDecodingStrategy = .iso8601
38	return try decoder.decode(DepsStatus.self, from: Data(json.utf8))	37	return try decoder.decode(DepsStatus.self, from: Data(json.utf8))
39	}	38	}
40		39

gitbayTests/DiscoveryTests.swift +1 −2

	@@ -15,8 +15,7 @@ private func makeClient() throws -> (GitbayClient, StubProtocol.Box) {
15	struct FeedEventTests {	15	struct FeedEventTests {
16		16
17	private func decode(_ json: String) throws -> FeedEvent {	17	private func decode(_ json: String) throws -> FeedEvent {
18	let decoder = JSONDecoder()	18	let decoder = GitbayClient.decoder()
19	decoder.dateDecodingStrategy = .iso8601
20	return try decoder.decode(FeedEvent.self, from: Data(json.utf8))	19	return try decoder.decode(FeedEvent.self, from: Data(json.utf8))
21	}	20	}
22		21

gitbayTests/MRLifecycleTests.swift +2 −4

 @testable import gitbay
 private func decodeDetail(_ json: String) throws -> MRDetail {
-    let decoder = JSONDecoder()
+    let decoder = GitbayClient.decoder()
-    decoder.dateDecodingStrategy = .iso8601
     return try decoder.decode(MRDetail.self, from: Data(json.utf8))
 }
 private func decodeRow(_ json: String) throws -> MergeRequest {
-    let decoder = JSONDecoder()
+    let decoder = GitbayClient.decoder()
-    decoder.dateDecodingStrategy = .iso8601
     return try decoder.decode(MergeRequest.self, from: Data(json.utf8))
 }

gitbayTests/MRViewModelTests.swift +1 −2

	@@ -384,8 +384,7 @@ struct ThreadAnchoringTests {
384	"comments":[{"id":1,"author":"krz","body":"why?",\	384	"comments":[{"id":1,"author":"krz","body":"why?",\
385	"created_at":"2026-08-20T10:30:00.000Z"}]}	385	"created_at":"2026-08-20T10:30:00.000Z"}]}
386	"""	386	"""
387	let decoder = JSONDecoder()	387	let decoder = GitbayClient.decoder()
388	decoder.dateDecodingStrategy = .iso8601
389	return try decoder.decode(ReviewThread.self, from: Data(json.utf8))	388	return try decoder.decode(ReviewThread.self, from: Data(json.utf8))
390	}	389	}
391		390

gitbayTests/NotificationTests.swift +1 −2

	@@ -23,8 +23,7 @@ private func argvOf(_ seen: StubProtocol.Seen) throws -> [String] {
23	}	23	}
24		24
25	private func decode(_ json: String) throws -> InboxNotification {	25	private func decode(_ json: String) throws -> InboxNotification {
26	let decoder = JSONDecoder()	26	let decoder = GitbayClient.decoder()
27	decoder.dateDecodingStrategy = .iso8601
28	return try decoder.decode(InboxNotification.self, from: Data(json.utf8))	27	return try decoder.decode(InboxNotification.self, from: Data(json.utf8))
29	}	28	}
30		29

gitbayTests/ReleaseTests.swift +1 −2

	@@ -161,8 +161,7 @@ struct ReleaseDetailViewModelTests {
161	struct FeedReleaseDestinationTests {	161	struct FeedReleaseDestinationTests {
162		162
163	@Test func releaseEventsNavigateToTheRelease() throws {	163	@Test func releaseEventsNavigateToTheRelease() throws {
164	let decoder = JSONDecoder()	164	let decoder = GitbayClient.decoder()
165	decoder.dateDecodingStrategy = .iso8601
166	let event = try decoder.decode(FeedEvent.self, from: Data("""	165	let event = try decoder.decode(FeedEvent.self, from: Data("""
167	{"id":2,"repo":"krz/gitbay","actor":"cmc","kind":"release.created",\	166	{"id":2,"repo":"krz/gitbay","actor":"cmc","kind":"release.created",\
168	"data":{"tag":"v1.0.0"},"created_at":"2026-08-26T05:27:36Z"}	167	"data":{"tag":"v1.0.0"},"created_at":"2026-08-26T05:27:36Z"}

gitbayTests/SearchTests.swift +2 −4

 struct SearchResultDecodingTests {
-    /// Matches the established direct-decode pattern in
+    /// Decodes with the client's own date strategy, as `DiscoveryTests` does.
-    /// `DiscoveryTests.swift`: a plain decoder with `.iso8601` dates.
     private func decode(_ json: String) throws -> [SearchResult] {
-        let decoder = JSONDecoder()
+        let decoder = GitbayClient.decoder()
-        decoder.dateDecodingStrategy = .iso8601
         return try decoder.decode([SearchResult].self, from: Data(json.utf8))
     }

gitbayUITests/LiveSmokeUITests.swift +19 −5

         default: break // follow the device, as a real launch does
         }
         app.launch()
+        // A fresh device — a clone on another runtime, say — starts on
+        // the token screen; the flows assume a signed-in app.
+        signInIfNeeded()
         if name.contains("testRepoManagementFlows") {
             deleteScratchRepo()
         }
         createdRow.tap()
         // A fresh MR has one revision; the section lists it.
-        let revisions = app.staticTexts["Revisions"].firstMatch
+        let revisions = header("Revisions")
         XCTAssertTrue(scrollTo(revisions, swipes: 8), "revisions section missing")
         XCTAssertTrue(app.staticTexts["v1"].firstMatch.exists, "first revision not listed")
     /// rows do not exist to XCUITest, so waitForExistence alone fails on
     /// anything below the fold.
     @discardableResult
+    /// A list section header. iOS 18 renders these uppercased and iOS 26
+    /// as written, so the match ignores case.
+    func header(_ text: String) -> XCUIElement {
+        app.staticTexts.matching(NSPredicate(format: "label ==[c] %@", text)).firstMatch
+    }
     func scrollTo(_ element: XCUIElement, swipes: Int = 6) -> Bool {
         for _ in 0..<swipes {
             if element.exists { return true }
         XCTAssertTrue(app.staticTexts["warez for the public"].firstMatch
             .waitForExistence(timeout: 15), "profile did not load")
         XCTAssertTrue(app.staticTexts
-            .containing(NSPredicate(format: "label BEGINSWITH 'Repositories'")).firstMatch
+            .containing(NSPredicate(format: "label BEGINSWITH[c] 'Repositories'")).firstMatch
             .waitForExistence(timeout: 10), "profile repos missing")
         back()
     }
     private func signInIfNeeded() {
+        // Signed in already: the tab bar is up and there is no token field.
+        if app.tabBars.firstMatch.waitForExistence(timeout: 10),
+           !app.secureTextFields.firstMatch.exists {
+            return
+        }
         let tokenField = app.secureTextFields.firstMatch
         guard tokenField.waitForExistence(timeout: 5) else { return }
         guard let token = ProcessInfo.processInfo.environment["GITBAY_UITEST_TOKEN"] else {
         XCTAssertTrue(app.staticTexts
             .containing(NSPredicate(format: "label CONTAINS 'Self-Hosting'")).firstMatch
             .waitForExistence(timeout: 20), "profile description missing")
-        XCTAssertTrue(app.staticTexts["Organizations"].firstMatch.exists,
+        XCTAssertTrue(header("Organizations").exists,
                       "org memberships missing")
         XCTAssertTrue(app.staticTexts["krz"].firstMatch.exists, "org row missing")
             .containing(NSPredicate(format: "label CONTAINS 'contributions in the last year'")).firstMatch),
             "activity graph missing")
         XCTAssertTrue(scrollTo(app.staticTexts
-            .containing(NSPredicate(format: "label BEGINSWITH 'Repositories'")).firstMatch),
+            .containing(NSPredicate(format: "label BEGINSWITH[c] 'Repositories'")).firstMatch),
             "repositories missing")
         // --- a log entry opens its commit ---
         XCTAssertTrue(main.waitForExistence(timeout: 20), "refs did not load")
         XCTAssertTrue(app.staticTexts["default"].firstMatch.exists,
                       "the default branch is not marked")
-        XCTAssertTrue(app.staticTexts["Tags"].firstMatch.exists, "tags section missing")
+        XCTAssertTrue(header("Tags").exists, "tags section missing")
         main.tap()
         // Tapping a ref browses the repository there.
         XCTAssertTrue(app.cells.firstMatch.waitForExistence(timeout: 20),

Commit 104dd73fbc

Commit `104dd73fbc`