Commit 5f0b73e4e6
Verified · cmc
Layout: unified · split
docs/superpowers/plans/2026-09-20-push-notifications.md +8 −1
| @@ -21,7 +21,14 @@ | ||
| 21 | 21 | - **The Xcode project uses `PBXFileSystemSynchronizedRootGroup`.** New `.swift` files under `gitbay/` and `gitbayTests/` are picked up automatically — do NOT edit `project.pbxproj` to add file references. Build settings are a different matter and Task 6 does edit them. |
| 22 | 22 | - **Merge requests are `mrs` on the wire**, never `merge_requests`. The path a notification carries is `<owner>/<repo>/<section>/<n>`. |
| 23 | 23 | - Comments explain *why*, in plain direct English, at the density of the surrounding code. No before/after commentary. |
| 24 | - **Do not run the full iOS test suite repeatedly.** Run the focused test, then the suite once before committing. | |
| 24 | - **`-only-testing:` silently passes with zero tests.** Task 2 found this: for a free `@Test` function outside a suite type, `xcodebuild -only-testing:gitbayTests/someTest test` reports `** TEST SUCCEEDED **` while `xcresulttool` shows `totalTestCount: 0`. A RED step still fails honestly, because a missing type is a compile error — but every GREEN step under that filter is meaningless. **Run the whole test target** and read the count: | |
| 25 | ||
| 26 | ```bash | |
| 27 | cd /Users/cmc/git/krz/gitbay-ios && xcodebuild -project gitbay.xcodeproj -scheme gitbay \ | |
| 28 | -destination 'platform=iOS Simulator,name=iPhone 16 Pro' test 2>&1 | tail -30 | |
| 29 | ``` | |
| 30 | ||
| 31 | Wherever a task below says `-only-testing:`, use this instead. The suite is small enough that the cost is seconds. | |
| 25 | 32 | |
| 26 | 33 | --- |
| 27 | 34 | |