Commit 79684292f4
79684292f4217774beb26b51ac4497438f866c56
parent: 54818d13ac
Unsigned
cmc <hello@cleberg.net> · 2026-09-30 05:13 UTC
Fix org-body freeze (org-swift 0.7.1); larger send buttons (!152)
- Freeze: an org comment with a line starting `#12 …` hung the app. `OrgParser.parse` looped forever on a `#` line that is neither a comment nor a `#+` keyword (fixed in krz/org-swift!10, tagged v0.7.1). The requirement moves to 0.7.1 and Package.resolved pins it. Reproduced by hosting IssueView with the real ios-smoke/ui-smoke-edit#1 payload: hung before, renders with links after.
- Send buttons (issue comment, MR comment, review reply): `.title` size, 44pt minimum hit area.
577 unit tests, Release build.
Layout: unified · split
gitbay.xcodeproj/project.pbxproj
+1 −1
| @@ -599,7 +599,7 @@ |
| 599 | repositoryURL = "ssh://git@gitbay.org/krz/org-swift.git"; |
599 | repositoryURL = "ssh://git@gitbay.org/krz/org-swift.git"; |
| 600 | requirement = { |
600 | requirement = { |
| 601 | kind = upToNextMinorVersion; |
601 | kind = upToNextMinorVersion; |
| 602 | minimumVersion = 0.7.0; |
602 | minimumVersion = 0.7.1; |
| 603 | }; |
603 | }; |
| 604 | }; |
604 | }; |
| 605 | 8B2898B0303FF3E5001BF44A /* XCRemoteSwiftPackageReference "Highlightr" */ = { |
605 | 8B2898B0303FF3E5001BF44A /* XCRemoteSwiftPackageReference "Highlightr" */ = { |
gitbay.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
+2 −2
| @@ -15,8 +15,8 @@ |
| 15 | "kind" : "remoteSourceControl", |
15 | "kind" : "remoteSourceControl", |
| 16 | "location" : "ssh://git@gitbay.org/krz/org-swift.git", |
16 | "location" : "ssh://git@gitbay.org/krz/org-swift.git", |
| 17 | "state" : { |
17 | "state" : { |
| 18 | "revision" : "d91c9b516062b4fb0742c83edfd0c16b8a7b1b9b", |
18 | "revision" : "fa46c3f1577091385a95ac5f5680409f09701004", |
| 19 | "version" : "0.7.0" |
19 | "version" : "0.7.1" |
| 20 | } |
20 | } |
| 21 | } |
21 | } |
| 22 | ], |
22 | ], |
gitbay/Views/Issues/IssueView.swift
+3
| @@ -191,6 +191,9 @@ struct IssueView: View { |
| 191 | Task { await model.comment(text, format: commentFormat) } |
191 | Task { await model.comment(text, format: commentFormat) } |
| 192 | } label: { |
192 | } label: { |
| 193 | Image(systemName: "arrow.up.circle.fill") |
193 | Image(systemName: "arrow.up.circle.fill") |
| |
194 | .font(.title) |
| |
195 | .frame(minWidth: 44, minHeight: 44) |
| |
196 | .contentShape(Rectangle()) |
| 194 | } |
197 | } |
| 195 | .accessibilityLabel("Send comment") |
198 | .accessibilityLabel("Send comment") |
| 196 | .disabled(commentText.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty |
199 | .disabled(commentText.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty |
gitbay/Views/MRs/MRView.swift
+6
| @@ -557,6 +557,9 @@ struct MRView: View { |
| 557 | Task { await model.comment(text, format: commentFormat) } |
557 | Task { await model.comment(text, format: commentFormat) } |
| 558 | } label: { |
558 | } label: { |
| 559 | Image(systemName: "arrow.up.circle.fill") |
559 | Image(systemName: "arrow.up.circle.fill") |
| |
560 | .font(.title) |
| |
561 | .frame(minWidth: 44, minHeight: 44) |
| |
562 | .contentShape(Rectangle()) |
| 560 | } |
563 | } |
| 561 | .accessibilityLabel("Send comment") |
564 | .accessibilityLabel("Send comment") |
| 562 | .disabled(commentText.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty |
565 | .disabled(commentText.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty |
| @@ -705,6 +708,9 @@ struct ReviewThreadView: View { |
| 705 | Task { await model.reply(to: thread, text) } |
708 | Task { await model.reply(to: thread, text) } |
| 706 | } label: { |
709 | } label: { |
| 707 | Image(systemName: "arrow.up.circle.fill") |
710 | Image(systemName: "arrow.up.circle.fill") |
| |
711 | .font(.title) |
| |
712 | .frame(minWidth: 44, minHeight: 44) |
| |
713 | .contentShape(Rectangle()) |
| 708 | } |
714 | } |
| 709 | .accessibilityLabel("Send reply") |
715 | .accessibilityLabel("Send reply") |
| 710 | .disabled(replyText.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty |
716 | .disabled(replyText.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty |