Commit `8af268e4f7`

8af268e4f7016de42e46fb95cffe10fa64780131

parent: f390bcc59e

Verified · cmc

cmc <hello@cleberg.net> · 2026-10-14 07:27 UTC

Transfer and delete: the screens underneath follow; refusals in view

The repository screen and the dashboard reload when a repository is
deleted, moved or renamed, rather than showing it until pulled; a
settings screen returned to after one keeps its notice instead of
reloading into not found. A refused rename, transfer or delete is shown
in an alert, since the screen's banner sits at the top of a long list.
A delete whose retry finds the repository gone is reported done.

Ref #31

Layout: unified · split

gitbay/Repos/RepoSettingsViewModel.swift +9

         defer { working = false }
         do {
             let renamed = try await client.run(["repo", "rename", repoPath, name], as: Renamed.self)
+            NotificationCenter.default.post(name: .gitbayRepositoryChanged, object: repoPath)
             return renamed?.repo
         } catch let error as GitbayError {
             actionError = error.userFacingMessage
         defer { working = false }
         do {
             let moved = try await client.run(["repo", "transfer", repoPath, owner], as: Transferred.self)
+            NotificationCenter.default.post(name: .gitbayRepositoryChanged, object: repoPath)
             return moved?.repo
         } catch let error as GitbayError {
             // The owner is typed: a refusal of it says what to fix.
         defer { working = false }
         do {
             try await client.run(["repo", "delete", repoPath, "--yes"])
+            NotificationCenter.default.post(name: .gitbayRepositoryChanged, object: repoPath)
+            return true
+        } catch GitbayError.notFound {
+            // The client retries a failure once. A delete that removed the
+            // row and then failed cleaning up answers the retry with not
+            // found: the repository is gone either way.
+            NotificationCenter.default.post(name: .gitbayRepositoryChanged, object: repoPath)
             return true
         } catch let error as GitbayError {
             actionError = error.userFacingMessage

gitbay/Views/Dashboard/DashboardView.swift +4

         .onReceive(NotificationCenter.default.publisher(for: .gitbaySavedQueriesChanged)) { _ in
             Task { await model.load() }
         }
+        // A pinned repository deleted or moved elsewhere.
+        .onReceive(NotificationCenter.default.publisher(for: .gitbayRepositoryChanged)) { _ in
+            Task { await model.load() }
+        }
         .onChange(of: model.state.value?.unread) { _, count in
             if let count { unread = count }
         }

gitbay/Views/Repos/RepoSettingsView.swift +18 −1

     @State private var deleteConfirm = ""
     /// Set once the repository is deleted: nothing on this screen applies.
     @State private var deleted = false
+    /// A refused rename, transfer or delete, shown where the user is: the
+    /// screen's banner sits at the top of a long list, out of sight.
+    @State private var refusal: String?
     @State private var loadedOnce = false
     @State private var removingTopic: String?
     @State private var newGrantUser = ""
         .navigationTitle("Settings")
         .navigationBarTitleDisplayMode(.inline)
         .task {
+            // A screen returned to after its repository moved or went has
+            // nothing to load; the notice is all it shows.
+            guard !deleted, renamedTo == nil else { return }
             await model.load()
             if !loadedOnce, let loaded = model.state.value {
                 descriptionText = loaded.detail.description ?? ""
         .task { await model.loadGrants() }
         .task { await model.loadBranches() }
         .refreshable {
+            // Nothing to reload once the repository is gone or moved.
+            guard !deleted, renamedTo == nil else { return }
             await model.load()
             await model.loadDeps()
             await model.loadGrants()
                 Task {
                     if let path = await model.rename(to: newName) {
                         renamedTo = path
+                    } else {
+                        refusal = model.actionError
                     }
                 }
             }
         } message: {
             Text("Clone URLs change. The old path stops resolving. Type \(model.repoPath) to confirm.")
         }
+        .alert("Not done", isPresented: Binding(get: { refusal != nil }, set: { if !$0 { refusal = nil } })) {
+            Button("OK", role: .cancel) {}
+        } message: {
+            Text(refusal ?? "")
+        }
         .alert("Transfer \(model.repoPath)", isPresented: $transferring) {
             TextField("New owner", text: $newOwner)
                 .autocorrectionDisabled()
                 Task {
                     if let path = await model.transfer(to: newOwner) {
                         renamedTo = path
+                    } else {
+                        refusal = model.actionError
                     }
                 }
             }
                 .textInputAutocapitalization(.never)
             Button("Delete", role: .destructive) {
                 Task {
-                    if await model.delete() { deleted = true }
+                    if await model.delete() { deleted = true } else { refusal = model.actionError }
                 }
             }
             .disabled(deleteConfirm != model.repoPath)

gitbay/Views/Repos/RepoView.swift +5

         .toolbar { toolbar }
         .task { await model.load() }
         .refreshable { await model.load() }
+        // Settings, pushed on top, may delete or move this repository;
+        // reloading turns this screen into the not-found it now is.
+        .onReceive(NotificationCenter.default.publisher(for: .gitbayRepositoryChanged)) { note in
+            if note.object as? String == path { Task { await model.load() } }
+        }
         .alert("Fork \(path)", isPresented: $confirmingFork) {
             TextField("New name (optional)", text: $forkName)
                 .autocorrectionDisabled()

gitbayTests/RepoTransferDeleteTests.swift +10

	@@ -59,4 +59,14 @@ struct RepoTransferDeleteTests {
59	#expect(!(await model.delete()))	59	#expect(!(await model.delete()))
60	#expect(model.actionError == "only the owner or an admin can delete cmc/app")	60	#expect(model.actionError == "only the owner or an admin can delete cmc/app")
61	}	61	}
		62
		63	@Test func aDeleteWhoseRetryFindsNothingIsDone() async throws {
		64	let (client, stub) = try makeClient()
		65	stub.enqueue(.init(status: 500, json: #"{"protocol_version":1,"error":"removing the directory: busy","exit_code":1}"#, match: "cmd"))
		66	stub.enqueue(.init(status: 404, json: #"{"protocol_version":1,"error":"no repository cmc/app","exit_code":3}"#, match: "cmd"))
		67	let model = RepoSettingsViewModel(client: client, repoPath: "cmc/app")
		68
		69	#expect(await model.delete())
		70	#expect(model.actionError == nil)
		71	}
62	}	72	}

Commit 8af268e4f7

Commit `8af268e4f7`