Commit `d7fac80c5f`

d7fac80c5f39e46eb7614e23711bbed89355757f

parent: ef8d699532

Verified · cmc

cmc <hello@cleberg.net> · 2026-09-29 02:49 UTC

Send the webhook secret on stdin

webhook add refuses `--secret <value>` since krz/gitbay#284. Send
`--secret -` and put the secret on stdin.

Closes #21

Layout: unified · split

gitbay/Repos/WebhookViewModels.swift +6 −5

         }
     }
-    /// `webhook add <repo> <url> [--secret <s>] [--events <e>]` — an empty
+    /// `webhook add <repo> <url> [--secret -] [--events <e>]` — an empty
     /// secret or event list is left out, so the server applies its default.
+    /// The secret travels on stdin; the server refuses it in argv.
     func add(url: String, secret: String, events: String) async -> Bool {
         let url = url.trimmingCharacters(in: .whitespaces)
         guard !url.isEmpty else { return false }
         var argv = ["webhook", "add", repoPath, url]
         let secret = secret.trimmingCharacters(in: .whitespaces)
-        if !secret.isEmpty { argv += ["--secret", secret] }
+        if !secret.isEmpty { argv += ["--secret", "-"] }
         let events = events.trimmingCharacters(in: .whitespaces)
         if !events.isEmpty { argv += ["--events", events] }
-        await perform(argv)
+        await perform(argv, stdin: secret.isEmpty ? nil : secret + "\n")
         return actionError == nil
     }
         await perform(["webhook", "remove", repoPath, String(id)])
     }
-    private func perform(_ argv: [String]) async {
+    private func perform(_ argv: [String], stdin: String? = nil) async {
         working = true
         actionError = nil
         defer { working = false }
         do {
-            try await client.run(argv)
+            try await client.run(argv, stdin: stdin)
             await load()
         } catch let error as GitbayError {
             actionError = error.userFacingMessage

gitbayTests/WebhookTests.swift +8 −1

     return try #require(body["argv"] as? [String])
 }
+private func stdinOf(_ seen: StubProtocol.Seen) throws -> String? {
+    let body = try #require(try JSONSerialization.jsonObject(with: seen.body) as? [String: Any])
+    return body["stdin"] as? String
+}
 private let okJSON = #"{"protocol_version":1,"data":{},"exit_code":0}"#
 private let hooksJSON = """
         #expect(first && second)
         let writes = try stub.seen.filter { $0.method == "POST" }.map(argvOf)
         #expect(writes == [
-            ["webhook", "add", "krz/gitbay", "https://a.example/h", "--secret", "s3", "--events", "push"],
+            ["webhook", "add", "krz/gitbay", "https://a.example/h", "--secret", "-", "--events", "push"],
             ["webhook", "add", "krz/gitbay", "https://b.example/h"],
         ])
+        let posts = stub.seen.filter { $0.method == "POST" }
+        #expect(try posts.map(stdinOf) == ["s3\n", nil])
     }
     @Test func removeSendsTheIdThenReloads() async throws {

Commit d7fac80c5f

Commit `d7fac80c5f`