Commit `f0267e5ff1`

f0267e5ff1f4ec8c6f74d945004377c7d8ce3973

parent: d5499b57f6

Verified · cmc

cmc <hello@cleberg.net> · 2026-09-20 23:57 UTC

push: register an account that signs in while the app runs

The spec names three registration events: the APNs token arriving, an
account signing in, and launch. Only two were wired, so an account
added while the app ran had no device row until the next cold launch.
SessionStore gains didAddAccount beside willRemoveAccount, fired at
the end of a successful signIn and pointed at the registrar in the
same place the removal hook is.

deviceToken is private rather than private(set): the registrar is in
the environment, so a readable token was one any view could put on a
screen.

Ref krz/gitbay#89

Layout: unified · split

gitbay/Auth/SessionStore.swift +7

         currentAccountID = account.id
         signedOutMessage = nil
         watchForRevocation(candidate, account: account)
+        await didAddAccount?(account)
     }
     /// A client for any signed-in account, active or not. Push
     /// nothing about push beyond that something wants to run first.
     var willRemoveAccount: ((Account) async -> Void)?
+    /// Runs after an account signs in, with its token stored. The
+    /// counterpart to `willRemoveAccount`: an account added while the
+    /// app runs has no push device row until something registers it,
+    /// and nothing else would until the next cold launch.
+    var didAddAccount: ((Account) async -> Void)?
     /// Switch to another stored account. Returns false if its token is
     /// gone from the Keychain, in which case the account is dropped too.
     @discardableResult

gitbay/Push/PushRegistrar.swift +15 −2

     private let defaults: UserDefaults
     /// The APNs token as lowercase hex, once iOS has handed it over.
-    private(set) var deviceToken: String?
+    /// Private rather than `private(set)`: this object is in the
+    /// environment, so a readable token would be one any view could
+    /// put on a screen.
+    private var deviceToken: String?
     init(session: SessionStore, defaults: UserDefaults = .standard) {
         self.session = session
         }
     }
+    /// Registers one account, for one that signs in while the app is
+    /// running. Does nothing until APNs has handed over a token; the
+    /// account is picked up by `registerAll` when it does.
+    func register(_ account: Account) async {
+        guard let token = deviceToken else { return }
+        await register(account, token: token)
+    }
     private func register(_ account: Account, token: String) async {
         guard let client = session.client(for: account) else { return }
         nonisolated struct Registered: Decodable, Sendable { let id: Int64 }
         await UNUserNotificationCenter.current().notificationSettings().authorizationStatus
     }
-    /// Re-registers on launch when permission is already granted.
+    /// Asks iOS for a token when permission is already granted: on
+    /// launch, and when the user grants it in Settings rather than
+    /// through the toggle. Idempotent — `device add` upserts.
     func registerIfAlreadyAuthorized() async {
         if await authorizationStatus() == .authorized {
             UIApplication.shared.registerForRemoteNotifications()

gitbay/gitbayApp.swift +3

                     session.willRemoveAccount = { [weak registrar] account in
                         await registrar?.deregister(account)
                     }
+                    session.didAddAccount = { [weak registrar] account in
+                        await registrar?.register(account)
+                    }
                     // A tap that launched the app reaches the delegate
                     // before this runs; it parked the payload.
                     appDelegate.deliverPendingNotification()

gitbayTests/PushRegistrarTests.swift +31

	@@ -85,6 +85,37 @@ struct PushRegistrarTests {
85	#expect(argv(of: removes[0]).last == "7")	85	#expect(argv(of: removes[0]).last == "7")
86	}	86	}
87		87
		88	// What SessionStore.didAddAccount calls: the account that just
		89	// signed in gets a row, and no other account is touched.
		90	@Test func registrarRegistersOneAccountOnDemand() async throws {
		91	let (session, box) = try await twoAccounts()
		92	box.enqueue(.init(status: 200, json: registeredJSON))
		93	box.enqueue(.init(status: 200, json: registeredJSON))
		94	let registrar = PushRegistrar(session: session, defaults: scratchDefaults())
		95	await registrar.deviceTokenArrived(Data([0x01]))
		96	let before = box.seen.count
		97
		98	box.enqueue(.init(status: 200, json: registeredJSON))
		99	await registrar.register(try #require(session.accounts.last))
		100
		101	let adds = box.seen.dropFirst(before).filter {
		102	argv(of: $0).starts(with: ["notifications", "device", "add"])
		103	}
		104	#expect(adds.count == 1)
		105	}
		106
		107	// There is nothing to register with before APNs answers; the
		108	// token's arrival then registers every account, this one included.
		109	@Test func registrarRegistersNothingBeforeTheTokenArrives() async throws {
		110	let (session, box) = try await twoAccounts()
		111	let registrar = PushRegistrar(session: session, defaults: scratchDefaults())
		112	let before = box.seen.count
		113
		114	await registrar.register(try #require(session.accounts.first))
		115
		116	#expect(box.seen.count == before)
		117	}
		118
88	// Registration is a side channel: a failure leaves the account working	119	// Registration is a side channel: a failure leaves the account working
89	// and is retried on the next launch, not surfaced.	120	// and is retried on the next launch, not surfaced.
90	@Test func registrarSurvivesAFailedRegistration() async throws {	121	@Test func registrarSurvivesAFailedRegistration() async throws {

gitbayTests/SessionClientTests.swift +29

	@@ -58,6 +58,35 @@ private func twoAccounts() async throws -> (SessionStore, StubProtocol.Box) {
58	#expect(session.client(for: victim) == nil)	58	#expect(session.client(for: victim) == nil)
59	}	59	}
60		60
		61	// The counterpart to the removal hook: an account added while the app
		62	// runs has no push device row until something registers it, and
		63	// nothing else does before the next cold launch.
		64	@Test @MainActor func signInRunsTheAddHook() async throws {
		65	let (session, box) = makeSession()
		66	var added: [String] = []
		67	session.didAddAccount = { added.append($0.id) }
		68
		69	box.enqueue(.init(status: 200, json: whoami))
		70	try await session.signIn(instanceURL: "https://gitbay.org", token: "t1")
		71
		72	#expect(added == [try #require(session.current).id])
		73	}
		74
		75	// A sign-in that stored nothing must not announce an account.
		76	@Test @MainActor func aFailedSignInDoesNotRunTheAddHook() async throws {
		77	let (session, box) = makeSession()
		78	var hookRan = false
		79	session.didAddAccount = { _ in hookRan = true }
		80
		81	box.enqueue(.init(status: 401, json: #"{"protocol_version":1,"error":"nope","exit_code":4}"#))
		82	await #expect(throws: (any Error).self) {
		83	try await session.signIn(instanceURL: "https://gitbay.org", token: "bad")
		84	}
		85
		86	#expect(hookRan == false)
		87	#expect(session.accounts.isEmpty)
		88	}
		89
61	// expire is reached only after the server has already rejected the	90	// expire is reached only after the server has already rejected the
62	// account's token with a 401 (revocation, or handle's	91	// account's token with a 401 (revocation, or handle's
63	// requiresReauthentication path), so a deregistration call carrying	92	// requiresReauthentication path), so a deregistration call carrying

Commit f0267e5ff1

Commit `f0267e5ff1`