Issue templates in the compose sheet !70

merged merged by cmc on 2026-09-07 17:19 UTC · krz/gitbay-ios:issue-templates into main

4 files changed, +65 −3

Layout: unified · split

gitbay/Issues/IssueCreateViewModel.swift +16 −1

 import Foundation
 import Observation
-/// `issue create <repo> --title <t> --file -`.
+/// One of `issue templates <repo>` — a body the compose sheet can start from.
+nonisolated struct IssueTemplate: Decodable, Sendable, Hashable, Identifiable {
+    let name: String
+    let body: String
+    var id: String { name }
+}
+/// `issue create <repo> --title <t> --file -`, and the repo's templates.
 @Observable
 @MainActor
 final class IssueCreateViewModel {
     private(set) var working = false
     private(set) var errorMessage: String?
+    private(set) var templates: [IssueTemplate] = []
     var format: String?
     private let client: GitbayClient
         let number: Int64
     }
+    /// `issue templates <repo>`. Templates are a convenience, so a failed
+    /// read leaves the sheet without them rather than surfacing an error.
+    func loadTemplates() async {
+        templates = (try? await client.readList(
+            ["issue", "templates", repoPath], of: IssueTemplate.self)) ?? []
+    }
     /// Returns the new issue's number, or nil with `errorMessage` set.
     func create(title: String, body: String) async -> Int64? {
         working = true

gitbay/Views/Issues/IssueListView.swift +3 −1

                 errorMessage: createModel.errorMessage,
                 title: $draftTitle,
                 bodyText: $draftBody,
-                format: $draftFormat
+                format: $draftFormat,
+                templates: createModel.templates
             ) {
                 createModel.format = draftFormat
                 Task {
             }
         }
         .task { await model.load() }
+        .task { await createModel.loadTemplates() }
         .refreshable { await model.load() }
     }
 }

gitbay/Views/Shared/ComposeSheet.swift +15 −1

     /// when the value changed and the picker kept whatever it first saw.
     @Binding var format: String
     let showsFormat: Bool
+    /// Issue templates to start the body from; empty hides the menu.
+    let templates: [IssueTemplate]
     let onSubmit: () -> Void
     /// A nil `format` hides the picker entirely — the release editor has
     /// no parity row and passes nothing, leaving that call site untouched.
     init(heading: String, submitLabel: String, working: Bool, errorMessage: String?,
          title: Binding<String>, bodyText: Binding<String>,
-         format: Binding<String>? = nil, onSubmit: @escaping () -> Void) {
+         format: Binding<String>? = nil, templates: [IssueTemplate] = [],
+         onSubmit: @escaping () -> Void) {
         self.heading = heading
         self.submitLabel = submitLabel
         self.working = working
         _bodyText = bodyText
         _format = format ?? .constant("md")
         showsFormat = format != nil
+        self.templates = templates
         self.onSubmit = onSubmit
     }
                         .accessibilityIdentifier("compose-title")
                 }
                 Section("Body") {
+                    if !templates.isEmpty {
+                        Menu {
+                            ForEach(templates) { template in
+                                Button(template.name) { bodyText = template.body }
+                            }
+                        } label: {
+                            Label("Template", systemImage: "doc.text")
+                        }
+                        .accessibilityIdentifier("compose-template-menu")
+                    }
                     TextEditor(text: $bodyText)
                         .frame(minHeight: 160)
                         .font(.gbSans(.body))

gitbayTests/ComposeViewModelTests.swift +31

	@@ -61,6 +61,37 @@ struct IssueCreateViewModelTests {
61	}	61	}
62	}	62	}
63		63
		64	@MainActor
		65	struct IssueTemplateTests {
		66
		67	@Test func loadTemplatesReadsTheRepoTemplates() async throws {
		68	let (client, stub) = try makeClient()
		69	stub.enqueue(.init(status: 200, json: """
		70	{"protocol_version":1,"data":[\
		71	{"name":"bug","body":"## Steps\\n\\n1. "},\
		72	{"name":"feature","body":"## Why\\n"}],"exit_code":0}
		73	"""))
		74	let model = IssueCreateViewModel(client: client, repoPath: "krz/gitbay")
		75
		76	await model.loadTemplates()
		77
		78	#expect(model.templates.map(\.name) == ["bug", "feature"])
		79	#expect(model.templates.first?.body == "## Steps\n\n1. ")
		80	#expect(stub.seen.first?.url.query() == "argv=issue&argv=templates&argv=krz/gitbay")
		81	}
		82
		83	@Test func aTemplateReadFailureLeavesNoTemplatesAndNoError() async throws {
		84	let (client, stub) = try makeClient()
		85	stub.enqueue(.init(status: 500, json: #"{"protocol_version":1,"error":"boom","exit_code":1}"#))
		86	let model = IssueCreateViewModel(client: client, repoPath: "krz/gitbay")
		87
		88	await model.loadTemplates()
		89
		90	#expect(model.templates.isEmpty)
		91	#expect(model.errorMessage == nil)
		92	}
		93	}
		94
64	@MainActor	95	@MainActor
65	struct MRCreateViewModelTests {	96	struct MRCreateViewModelTests {
66		97