Commit 433da19b99

433da19b990b08332cd58577b0d97038e34c0dc5

parent: b0b75f8f4c

Verified · cmc

cmc <hello@cleberg.net> · 2026-09-11 16:19 UTC

web: the milestone picker skips the readable scope, org links follow visibility

The issue page computed the readable repository set only to feed
ListMilestones, whose counts the picker does not show. The org page's
labels and milestones links now render with the repository list, so a
viewer who can see nothing under the org is not offered two 404s.

Ref #203

Layout: unified · split

internal/httpd/web.go +2 −6
@@ -1709,12 +1709,8 @@ func (s *Server) issue(w http.ResponseWriter, r *http.Request) {
1709 return 1709 return
1710 } 1710 }
1711 md := s.ugcFor(r, p.Repo) 1711 md := s.ugcFor(r, p.Repo)
1712 readable, err := control.ReadableScope(s.st, s.viewer(r), p.Repo) 1712 // nil readable: the picker lists titles, never the progress counts.
1713 if err != nil { 1713 milestones, _ := s.st.ListMilestones(p.Repo, "open", nil)
1714 http.Error(w, "internal error", http.StatusInternalServerError)
1715 return
1716 }
1717 milestones, _ := s.st.ListMilestones(p.Repo, "open", readable)
1718 s.render(w, "issue.html", struct { 1714 s.render(w, "issue.html", struct {
1719 repoPage 1715 repoPage
1720 Issue store.Issue 1716 Issue store.Issue
internal/web/templates/owner.html +1 −1
@@ -7,7 +7,7 @@
7{{if .Profile.Links}}<p class="meta">{{range $i, $l := .Profile.Links}}{{if $i}} · {{end}}<a href="{{$l.URL}}" rel="nofollow me">{{if $l.Label}}{{$l.Label}}{{else}}{{$l.URL}}{{end}}</a>{{end}}</p>{{end}} 7{{if .Profile.Links}}<p class="meta">{{range $i, $l := .Profile.Links}}{{if $i}} · {{end}}<a href="{{$l.URL}}" rel="nofollow me">{{if $l.Label}}{{$l.Label}}{{else}}{{$l.URL}}{{end}}</a>{{end}}</p>{{end}}
8{{if .Orgs}}<p class="meta">member of {{range .Orgs}}<a class="memberchip" href="/{{.Name}}">{{.Name}}</a> {{end}}</p>{{end}} 8{{if .Orgs}}<p class="meta">member of {{range .Orgs}}<a class="memberchip" href="/{{.Name}}">{{.Name}}</a> {{end}}</p>{{end}}
9{{if .Members}}<p class="meta">members {{range .Members}}<a class="memberchip" href="/{{.Name}}">{{.Name}} <span class="role">{{.Role}}</span></a> {{end}}</p>{{end}} 9{{if .Members}}<p class="meta">members {{range .Members}}<a class="memberchip" href="/{{.Name}}">{{.Name}} <span class="role">{{.Role}}</span></a> {{end}}</p>{{end}}
10{{if eq .Kind "org"}}<p class="meta"><a href="/{{.Owner}}/-/labels">labels</a> · <a href="/{{.Owner}}/-/milestones">milestones</a></p>{{end}} 10{{if and (eq .Kind "org") .Repos}}<p class="meta"><a href="/{{.Owner}}/-/labels">labels</a> · <a href="/{{.Owner}}/-/milestones">milestones</a></p>{{end}}
11</section> 11</section>
12{{if .AboutHTML}}<section class="readme"><div class="rendered">{{.AboutHTML}}</div></section>{{end}} 12{{if .AboutHTML}}<section class="readme"><div class="rendered">{{.AboutHTML}}</div></section>{{end}}
13<section class="activity"> 13<section class="activity">