Commit `8eea89a307`

8eea89a307ad38ce5f8d5582906379040cf75983

parent: 0c16f309f5

Verified · cmc ci/build: success ci/test: success ci/vuln: success

cmc <hello@cleberg.net> · 2026-09-03 01:03 UTC

e2e: an instance is ready on every listener before a test starts

startInstanceWith returned once the SSH port answered. The HTTP and
git listeners come up in their own goroutines, so a test whose first
act was an HTTP request could reach the port before it was bound and be
refused: TestWebSignup in build 331 and TestHealthz in build 358, both
a second into the test, both green in the next run.

The harness now waits for the SSH, HTTP and git ports alike, with the
same probe the LFS test already used for a restart.

Closes #91

Layout: unified · split

e2e/ssh_test.go +6 −13

 	"path/filepath"
 	"strings"
 	"testing"
-	"time"
 )
 type instance struct {
 		inst.proc.Wait()
 	})
-	// Wait for the listener.
+	// Every listener, not just SSH: the HTTP and git ones come up in their
-	deadline := time.Now().Add(10 * time.Second)
+	// own goroutines, and a test whose first act is an HTTP request used
-	for {
+	// to race them and be refused.
-		conn, err := net.DialTimeout("tcp", fmt.Sprintf("127.0.0.1:%d", inst.port), 200*time.Millisecond)
+	for _, port := range []int{inst.port, inst.httpPort, inst.gitPort} {
-		if err == nil {
+		waitForPort(t, port)
-			conn.Close()
-			return inst
-		}
-		if time.Now().After(deadline) {
-			t.Fatal("gitbayd did not start listening")
-		}
-		time.Sleep(50 * time.Millisecond)
 	}
+	return inst
 }
 // admin runs a gitbayd admin command against the instance's database.

Commit 8eea89a307

Commit `8eea89a307`