Commit `97f30bdded`

97f30bdded6a11ef15e23b40d677af665f8b9d09

parent: e359304464

Verified · cmc ci/build: success ci/test: success

cmc <hello@cleberg.net> · 2026-09-20 04:41 UTC

e2e: the feed line no longer draws a build state

The dashboard feed dropped its state dot, so the end-to-end test can no
longer assert one. Folding two jobs into a run and taking the worse of
their outcomes is unchanged and covered by TestFeedLinesFoldsBuildRun.

e2e/dashboard_test.go +4 −6

		@@ -356,9 +356,10 @@ func TestDashboardQueues(t *testing.T) {
356	356	}
357	357	}
358	358
359		// D04/D05: two jobs on one commit fold into a single feed line, marked
360		// with the worse of the two outcomes, and shown with a relative time
361		// carrying the exact UTC time in its title.
	359	// D04/D05: two jobs on one commit fold into a single feed line, shown
	360	// with a relative time carrying the exact UTC time in its title. The
	361	// folded line's state is the worse of the two, which the feed no longer
	362	// draws; TestFeedLinesFoldsBuildRun covers that rule.
362	363	func TestDashboardFeedFoldsBuildRun(t *testing.T) {
363	364	inst := startInstanceWith(t, "[web]\nmode = \"accounts\"\n")
364	365	inst.runner = buildRunner(t)
		@@ -392,9 +393,6 @@ func TestDashboardFeedFoldsBuildRun(t *testing.T) {
392	393	if !strings.Contains(body, "ran 2 jobs on") {
393	394	t.Fatalf("feed did not fold the two jobs into one run:\n%s", body)
394	395	}
395		if !strings.Contains(body, `class="dot bad"`) {
396		t.Fatalf("feed did not mark the run with the worse (failure) status:\n%s", body)
397		}
398	396	if !strings.Contains(body, sha[:10]) {
399	397	t.Fatalf("feed missing the short sha %q:\n%s", sha[:10], body)
400	398	}

Commit 97f30bdded

Commit `97f30bdded`