Commit `b172654262`

b1726542625889e46518940b97cd2df8b9ccd998

parent: fe8361c849

Verified · cmc ci/build: success ci/test: success ci/vuln: success

cmc <hello@cleberg.net> · 2026-09-01 05:24 UTC

backup: archives inherit the database's mode, not the umask default

The nightly archive and the hourly database snapshot both contain the whole
database and both landed 0644. /var/backups/gitbay is 0750 so traversal
blocked other users, the same containment the live database had, and the
same reason to fix the file anyway.

umask 027 in both scripts, and the db subdirectory is created 0750 rather
than inheriting 0755 from mkdir.

Ref #28

Layout: unified · split

deploy/cloud-init.yaml +5

		@@ -215,6 +215,8 @@ write_files:
215	215	# Nightly consistent backup; keeps the last 7 locally.
216	216	# To ship offsite, add an rclone/s3 upload of $out here.
217	217	set -eu
	218	# The archive carries the database, so it gets the database's mode.
	219	umask 027
218	220	dir=/var/backups/gitbay
219	221	out="$dir/gitbay-$(date -u +%Y%m%d-%H%M%S).tar.gz"
220	222	/usr/local/bin/gitbayd --config /etc/gitbay/config.toml admin backup --out "$out"
		@@ -229,8 +231,11 @@ write_files:
229	231	content: \|
230	232	#!/bin/sh
231	233	set -eu
	234	# The archive is the whole database, so it gets the database's mode.
	235	umask 027
232	236	dir=/var/backups/gitbay/db
233	237	mkdir -p "$dir"
	238	chmod 0750 "$dir"
234	239	out="$dir/gitbay-db-$(date -u +%Y%m%d-%H%M%S).tar.gz"
235	240	/usr/local/bin/gitbayd --config /etc/gitbay/config.toml admin backup --db-only --out "$out"
236	241	ls -1t "$dir"/gitbay-db-*.tar.gz \| tail -n +49 \| xargs -r rm --

Commit b172654262

Commit `b172654262`