Commit `b4e14d4383`

b4e14d43830b28ba188f893db6f7b015bbb56729

parent: dcd93804bc

Verified · cmc

cmc <hello@cleberg.net> · 2026-09-28 07:39 UTC

store: failed step and reason on a build

Ref #266

Layout: unified · split

internal/store/builds.go +24 −2

 	// Trusted is false for a merge request head fetched from another
 	// repository: its steps run without the target's secrets.
 	Trusted bool
+	// FailedStep is the 1-based step a failed build stopped at, 0 when it
+	// stopped before its first step or did not fail. FailedReason is the
+	// runner's one line: "exit 1", "build timed out after 45m0s".
+	FailedStep   int
+	FailedReason string
 }
 // MaxBuildLog caps a build's stored log; appends past it are dropped.
 }
 const buildSelect = `
-	SELECT id, repo_id, number, job, sha, ref, steps, image, tree, status, created_at, started_at, finished_at, log_closed_at, trusted
+	SELECT id, repo_id, number, job, sha, ref, steps, image, tree, status, created_at, started_at, finished_at, log_closed_at, trusted,
+	       failed_step, failed_reason
 	FROM builds`
 func scanBuild(row interface{ Scan(...any) error }) (Build, error) {
 	var b Build
 	var trusted int
 	err := row.Scan(&b.ID, &b.RepoID, &b.Number, &b.Job, &b.SHA, &b.Ref, &b.Steps, &b.Image, &b.Tree,
-		&b.Status, &b.CreatedAt, &b.StartedAt, &b.FinishedAt, &b.LogClosedAt, &trusted)
+		&b.Status, &b.CreatedAt, &b.StartedAt, &b.FinishedAt, &b.LogClosedAt, &trusted,
+		&b.FailedStep, &b.FailedReason)
 	b.Trusted = trusted != 0
 	return b, err
 }
 	return nil
 }
+// SetBuildFailure records where a running build failed. The runner
+// reports it with the outcome; it is written first, so a reader woken
+// by the finish sees both.
+func (s *Store) SetBuildFailure(id int64, step int, reason string) error {
+	res, err := s.DB.Exec(`UPDATE builds SET failed_step = ?, failed_reason = ?
+		WHERE id = ? AND status = 'running'`, step, reason, id)
+	if err != nil {
+		return err
+	}
+	if n, _ := res.RowsAffected(); n == 0 {
+		return ErrNotFound
+	}
+	return nil
+}
 func (s *Store) BuildByID(id int64) (Build, error) {
 	b, err := scanBuild(s.DB.QueryRow(buildSelect+" WHERE id = ?", id))
 	if errors.Is(err, sql.ErrNoRows) {

internal/store/builds_test.go +35

	@@ -1,6 +1,7 @@
1	package store	1	package store
2		2
3	import (	3	import (
		4	"errors"
4	"strings"	5	"strings"
5	"testing"	6	"testing"
6	)	7	)
	@@ -566,3 +567,37 @@ func TestBuildLogFrom(t *testing.T) {
566	t.Fatalf("missing build: %v", err)	567	t.Fatalf("missing build: %v", err)
567	}	568	}
568	}	569	}
		570
		571	// Where a failed build stopped is recorded while it runs, before the
		572	// outcome, and a finished build is not rewritten (#266).
		573	func TestSetBuildFailure(t *testing.T) {
		574	s := open(t)
		575	if err := s.MigrateUp(); err != nil {
		576	t.Fatal(err)
		577	}
		578	uid, _ := s.CreateUser("cmc", true)
		579	repoID, _ := s.CreateRepo("user", uid, "app", "public")
		580	if _, err := s.CreateBuild(repoID, "unit", "abc", "main", `["true","false"]`, "", "", true); err != nil {
		581	t.Fatal(err)
		582	}
		583	b, ok, err := s.ClaimBuild(nil, false)
		584	if err != nil \|\| !ok {
		585	t.Fatalf("claim: ok=%v err=%v", ok, err)
		586	}
		587	if err := s.SetBuildFailure(b.ID, 2, "exit 1"); err != nil {
		588	t.Fatal(err)
		589	}
		590	if err := s.FinishBuild(b.ID, "failure"); err != nil {
		591	t.Fatal(err)
		592	}
		593	got, err := s.BuildByID(b.ID)
		594	if err != nil {
		595	t.Fatal(err)
		596	}
		597	if got.FailedStep != 2 \|\| got.FailedReason != "exit 1" {
		598	t.Fatalf("failed step %d reason %q", got.FailedStep, got.FailedReason)
		599	}
		600	if err := s.SetBuildFailure(b.ID, 1, "late"); !errors.Is(err, ErrNotFound) {
		601	t.Fatalf("rewrote a finished build: %v", err)
		602	}
		603	}

internal/store/migrations/0065_build_failure.down.sql added +2

@@ -0,0 +1,2 @@
	1	ALTER TABLE builds DROP COLUMN failed_reason;
	2	ALTER TABLE builds DROP COLUMN failed_step;

internal/store/migrations/0065_build_failure.up.sql added +4

@@ -0,0 +1,4 @@
	1	-- Where a failed build stopped: the 1-based step, 0 when it stopped
	2	-- before any step or did not fail, and the runner's one-line reason.
	3	ALTER TABLE builds ADD COLUMN failed_step INTEGER NOT NULL DEFAULT 0;
	4	ALTER TABLE builds ADD COLUMN failed_reason TEXT NOT NULL DEFAULT '';

Commit b4e14d4383

Commit `b4e14d4383`