| @@ -62,10 +62,14 @@ and the wait still wakes the loop. |
| 62 | `Ctx` gains `Done <-chan struct{}`, nil when the surface has none. The |
62 | `Ctx` gains `Done <-chan struct{}`, nil when the surface has none. The |
| 63 | embedded sshd closes it when the session's channel closes (the CLI's |
63 | embedded sshd closes it when the session's channel closes (the CLI's |
| 64 | shared connection outlives a Ctrl-C, the channel does not); `gitbayd |
64 | shared connection outlives a Ctrl-C, the channel does not); `gitbayd |
| 65 | shell` passes nil, since its process ends with the session. httpd sets |
65 | shell` still passes nil, but its process does not end with the |
| 66 | it from `r.Context()` on the web and both API endpoints. A write |
66 | session: OpenSSH closes the child's pipes and sends no signal to a |
| 67 | error also ends the loop. On `Done` the command returns |
67 | session with no pty, so a follow there ends at its next write, at the |
| 68 | `protocol.ExitFailure` with no message; nobody is reading. |
68 | build's outcome, or at the queued limit below; the per-account cap is |
| |
69 | per process in that mode. httpd sets it from `r.Context()` on the web |
| |
70 | and both API endpoints. A write error also ends the loop. On `Done` |
| |
71 | the command returns `protocol.ExitFailure` with no message; nobody is |
| |
72 | reading. |
| 69 | |
73 | |
| 70 | At most 8 follows per account run at once (a counter in `control`, |
74 | At most 8 follows per account run at once (a counter in `control`, |
| 71 | decremented on return). The ninth exits 4: "8 follows are already open |
75 | decremented on return). The ninth exits 4: "8 follows are already open |
| @@ -73,13 +77,23 @@ for this account; close one and retry". Signed-out web viewers are |
| 73 | account 0 and share the 8; the ninth gets the stored log once with the |
77 | account 0 and share the 8; the ninth gets the stored log once with the |
| 74 | refusal under it. |
78 | refusal under it. |
| 75 | |
79 | |
| |
80 | Nothing reaps a queued build (`ReapStaleBuilds` only reaps `running` |
| |
81 | builds), and a running one is already bounded by the reaper's |
| |
82 | deadline, so a follow of a build that stays `pending` ends on its own |
| |
83 | after `followQueued` (10 minutes), writing to stderr `build <n> is |
| |
84 | still queued; nothing claimed it in 10m0s. Follow again once a runner |
| |
85 | has.` and exiting `protocol.ExitFailure`. The clock runs only while the |
| |
86 | follow has seen the build `pending`; once it sees `running` or a |
| |
87 | terminal status the limit no longer applies. |
| |
88 | |
| 76 | The CLI's `pass("log", …)` help in `cmd/gitbay/main.go` names |
89 | The CLI's `pass("log", …)` help in `cmd/gitbay/main.go` names |
| 77 | `--follow`. |
90 | `--follow`. |
| 78 | |
91 | |
| 79 | ## Web |
92 | ## Web |
| 80 | |
93 | |
| 81 | `GET /{owner}/{repo}/builds/{n}` streams when the build is `pending` or |
94 | `GET /{owner}/{repo}/builds/{n}` streams when the build is `pending` or |
| 82 | `running` and the query has no `follow=0`. Otherwise it renders as now. |
95 | `running`, the query has no `follow=0`, and the method is `GET`. A HEAD |
| |
96 | request (the route also matches it) renders once, like `?follow=0`. |
| 83 | |
97 | |
| 84 | Streaming: |
98 | Streaming: |
| 85 | |
99 | |
| @@ -89,10 +103,17 @@ Streaming: |
| 89 | 3. Dispatch `build log <repo> <n> --follow` with `Stdout` an escaping |
103 | 3. Dispatch `build log <repo> <n> --follow` with `Stdout` an escaping |
| 90 | writer (`template.HTMLEscape` per chunk, then flush through |
104 | writer (`template.HTMLEscape` per chunk, then flush through |
| 91 | `http.ResponseController`) and `Done` from the request context. |
105 | `http.ResponseController`) and `Done` from the request context. |
| 92 | 4. After the command returns, read the build and write |
106 | 4. If the request context is done (the client left), write nothing |
| 93 | `<p class="notice" role="status">build finished: <status></p>` after |
107 | more. Otherwise write the `</pre>` that begins the tail, then, by |
| 94 | the `</pre>` that begins the tail, then the rest of the tail. A |
108 | the command's exit code: `ExitOK` reads the build and writes |
| 95 | dropped connection writes nothing more. |
109 | `<p class="notice" role="status">build finished: <status></p>`; |
| |
110 | `ExitDenied` (the follow cap) writes the stored log once above the |
| |
111 | `</pre>` and an error paragraph with the refusal, except a |
| |
112 | signed-out viewer (`viewer.ID == 0`) gets "Too many signed-out |
| |
113 | viewers are watching live builds. This is the log so far; reload to |
| |
114 | try again, or sign in." instead of the command's account-scoped |
| |
115 | wording; `ExitFailure` with a message (the queued limit) writes it |
| |
116 | as a `<p class="notice" role="status">`. Then the rest of the tail. |
| 96 | |
117 | |
| 97 | `build.html`, when `Live`, puts a line above the log: the log streams |
118 | `build.html`, when `Live`, puts a line above the log: the log streams |
| 98 | until the build ends; a stream that stops with no "build finished" line |
119 | until the build ends; a stream that stops with no "build finished" line |