No graceful shutdown: a deploy restart cuts in-flight pushes and builds #105

closed cmc opened this on 2026-09-03 05:13 UTC · ops · milestone v1.9.0

Discussion

cmc 2026-09-03 05:13 UTC

serve blocks on an error channel and never traps a signal or calls Shutdown; there is no signal.Notify in cmd/gitbayd or internal/httpd. Every make deploy restart (deploy/install.sh) can interrupt a receive-pack mid-write, a build-log append or a webhook delivery, and the webhook and mirror worker contexts are never cancelled.

Remedy: trap SIGTERM, Shutdown the HTTP server with a deadline, cancel worker contexts, drain the SSH listener.

closed by commit 3a7b3219b3 by cmc: gitbayd: header and idle timeouts, and a drain on SIGTERM

2026-09-03 17:10 UTC