Review model: no draft MRs, no batched review, no range-diff #111

closed cmc opened this on 2026-09-03 05:14 UTC · mr review · milestone v1.13.0

Discussion

cmc 2026-09-03 05:14 UTC
  • mr create has no --draft (mr.go:35).
  • A review is one verdict per call (mr.go:783); diff comments post immediately (diffcomment.go:33). A reviewer cannot compose a review and submit it as a unit.
  • Any head change stales every review (store/mrs.go:239) and threads by SHA equality (diffcomment.go:175), with nothing showing what changed between pushes.
  • mr diff truncates silently at 4 MiB (gitutil/merge.go:103, mr.go:635).

Remedy: a draft flag first; a pending-review batch second; a truncation notice today.

referenced in commit 6f184c2936 by cmc: mr: a merge request can say it is not asking yet

2026-09-04 17:13 UTC

referenced in commit 46a896187a by cmc: mr: a review is composed and submitted as one thing

2026-09-04 17:40 UTC

closed by commit e99285743d by cmc: mr: what changed between two revisions of a merge request

2026-09-04 17:40 UTC