mr: suggested changes in review comments #288

closed cmc opened this on 2026-09-28 06:27 UTC · mr review roadmap

Discussion

cmc 2026-09-28 06:27 UTC

A reviewer proposes replacement lines in a diff comment and the author applies them.

A fenced suggestion block in a mr diff-comment body replaces the anchored line range. Rendered as a diff on the MR page and in mr threads.
Applying produces a commit on the source branch. The server has no signing key, so on a repository with require-signed the server cannot make that commit. There the CLI applies it locally (mr apply-suggestion <n> <thread> fetches, patches, commits with the user's key, pushes); the web shows the command. On other repositories the web can apply it directly.
A suggestion whose anchor is stale cannot be applied.
Applying resolves the thread.

closed by cmc in commit 1346335ed2: wiki, changelog: suggested changes in review threads

2026-09-29 05:36 UTC

referenced in commit 39ca1bd78c by cmc: gitutil, control: BlobBatch skips a refused object without reading it in; suggestion blob cache capped at 8 MiB; range input on the split-layout compose form

2026-09-29 05:36 UTC

referenced in commit 714995cd86 by cmc: hookd: tests call control.QueueTagBuilds directly

2026-09-29 05:36 UTC

referenced in commit e56e8ca1bb by cmc: cli: mr apply-suggestion takes --json on both paths; a local apply whose thread stays open warns and exits 0

2026-09-29 05:36 UTC

referenced in commit 2faceb4c41 by cmc: control: apply-suggestion resolves the thread only for those who may, and exits 0 once the commit lands

2026-09-29 05:36 UTC

referenced in commit 65a1d7220c by cmc: control: apply-suggestion and repo commit-file refuse past the owner's storage quota

2026-09-29 05:36 UTC

referenced in commit 65ec67cc47 by cmc: control: read suggestion anchors once per file and commit, blobs through one cat-file --batch

2026-09-29 05:36 UTC

referenced in commit 421defaffc by cmc: cli: mr apply-suggestion commits and signs locally where the repository requires signed commits

2026-09-29 05:36 UTC

referenced in commit 89a6bbd4c1 by cmc: web: suggestions render as a diff in their thread, with an apply button or the CLI command; line ranges in the compose form

2026-09-29 05:36 UTC

referenced in commit 94e954df77 by cmc: control: mr apply-suggestion commits a thread's suggestion to the source branch

2026-09-29 05:36 UTC

referenced in commit 6b8e159687 by cmc: control, gitutil: post-receive's ref-update work as control.RefsUpdated; CommitWithFile

2026-09-29 05:36 UTC

referenced in commit 5271aa8b0d by cmc: control: suggestion blocks in diff comments, line ranges, suggestions in mr threads

2026-09-29 05:36 UTC

referenced in commit 9581d34d47 by cmc: suggest: parse suggestion blocks and apply them to a line range

2026-09-29 05:36 UTC