Commit `e2a9508577`

e2a9508577f3c0d69dccad0c098a6da7fd95a363

parent: 9d88cda282

Verified · cmc

cmc <hello@cleberg.net> · 2026-04-11 19:23 UTC

feat: run an initial poll when scheduler starts

Layout: unified · split

src/srht_contrib/main.py +12

 from collections.abc import AsyncIterator
 from contextlib import asynccontextmanager
+import logging
 from apscheduler.schedulers.background import BackgroundScheduler
 from fastapi import FastAPI
 from srht_contrib.utils.identity import ActorIdentityResolver
+logger = logging.getLogger(__name__)
 def build_poller(settings: Settings) -> PollerService:
     todo_client = SourceHutGraphQLClient(settings.todo_srht_endpoint, settings.srht_token)
     git_client = SourceHutGraphQLClient(settings.git_srht_endpoint, settings.srht_token)
                 replace_existing=True,
             )
             scheduler.start()
+            _run_startup_poll(app)
         app.state.scheduler = scheduler
         try:
             yield
         db.close()
+def _run_startup_poll(app: FastAPI) -> None:
+    try:
+        _scheduled_poll(app)
+    except Exception:
+        logger.exception("Initial scheduled poll failed during application startup")
 app = create_app()

tests/test_polling_api.py +31

	@@ -19,6 +19,7 @@ class InsertingPoller:
19	service = type("Service", (), {"client": _Closable()})()	19	service = type("Service", (), {"client": _Closable()})()
20	self.todo_service = service	20	self.todo_service = service
21	self.git_service = service	21	self.git_service = service
		22	self.tracked_poll_calls: list[str] = []
22		23
23	def track_actor_request(self, db, actor: str, *, update_last_requested: bool = True):	24	def track_actor_request(self, db, actor: str, *, update_last_requested: bool = True):
24	tracked_actor = db.scalar(select(TrackedActor).where(TrackedActor.actor == actor))	25	tracked_actor = db.scalar(select(TrackedActor).where(TrackedActor.actor == actor))
	@@ -47,6 +48,12 @@ class InsertingPoller:
47	db.commit()	48	db.commit()
48	return 1	49	return 1
49		50
		51	def poll_tracked_actors(self, db, default_actor: str \| None = None) -> dict[str, int]:
		52	if default_actor is not None:
		53	self.tracked_poll_calls.append(default_actor)
		54	return {default_actor: self.poll_all(db, default_actor)}
		55	return {}
		56
50		57
51	class FailingPoller:	58	class FailingPoller:
52	def __init__(self) -> None:	59	def __init__(self) -> None:
	@@ -65,6 +72,9 @@ class FailingPoller:
65	def poll_all(self, db, actor: str) -> int:	72	def poll_all(self, db, actor: str) -> int:
66	raise SourceHutClientError("boom")	73	raise SourceHutClientError("boom")
67		74
		75	def poll_tracked_actors(self, db, default_actor: str \| None = None) -> dict[str, int]:
		76	raise SourceHutClientError("boom")
		77
68		78
69	def test_manual_poll_uses_same_database_session(settings: Settings, db_engine, session_factory) -> None:	79	def test_manual_poll_uses_same_database_session(settings: Settings, db_engine, session_factory) -> None:
70	app = create_app(settings, engine=db_engine, session_factory=session_factory, poller=InsertingPoller())	80	app = create_app(settings, engine=db_engine, session_factory=session_factory, poller=InsertingPoller())
	@@ -89,3 +99,24 @@ def test_manual_poll_maps_sourcehut_failures_to_502(settings: Settings, db_engin
89		99
90	assert response.status_code == 502	100	assert response.status_code == 502
91	assert "SourceHut polling failed" in response.json()["detail"]	101	assert "SourceHut polling failed" in response.json()["detail"]
		102
		103
		104	def test_scheduler_runs_initial_poll_on_startup(settings: Settings, db_engine, session_factory) -> None:
		105	scheduler_settings = settings.model_copy(update={"enable_scheduler": True})
		106	poller = InsertingPoller()
		107	app = create_app(scheduler_settings, engine=db_engine, session_factory=session_factory, poller=poller)
		108
		109	with TestClient(app):
		110	pass
		111
		112	assert poller.tracked_poll_calls == ["~ccleberg"]
		113
		114
		115	def test_startup_poll_failure_does_not_block_app_start(settings: Settings, db_engine, session_factory) -> None:
		116	scheduler_settings = settings.model_copy(update={"enable_scheduler": True})
		117	app = create_app(scheduler_settings, engine=db_engine, session_factory=session_factory, poller=FailingPoller())
		118
		119	with TestClient(app) as client:
		120	response = client.get("/health")
		121
		122	assert response.status_code == 200

Commit e2a9508577

Commit `e2a9508577`