Commit `0dca8dc832`

0dca8dc832adedf57c8a6e9516fb258b0f681638

parent: 91f87b483b

Unsigned

cmc <hello@cleberg.net> · 2026-08-22 23:06 UTC
committer: <noreply@github.com>

Render seen alerts as seen instead of dropping them (#46)

Marking an alert seen removed the row for the session, then the next
poll put it back rendered identically, so the action looked like it had
done nothing.

The row now stays and recedes: dimmed, with a filled checkmark. Hiding
an alert is what dismiss and snooze are for. The control is a toggle, so
acknowledging isn't a one-way door.

markSeen becomes setSeen(_:_:).

Layout: unified · split

octosentry/SecurityEventListView.swift +1 −1

	@@ -313,7 +313,7 @@ struct SecurityEventListView: View {
313	: nil,	313	: nil,
314	isHidden: store.triage.isHidden(event.id, now: .now),	314	isHidden: store.triage.isHidden(event.id, now: .now),
315	snoozedUntil: store.triage.snoozedUntil(event.id, now: .now),	315	snoozedUntil: store.triage.snoozedUntil(event.id, now: .now),
316	onMarkSeen: { Task { await store.markSeen(event.id) } },	316	onToggleSeen: { Task { await store.setSeen(event.id, !event.seenLocally) } },
317	onDismiss: { Task { await store.dismiss(event.id) } },	317	onDismiss: { Task { await store.dismiss(event.id) } },
318	onSnooze: { duration in	318	onSnooze: { duration in
319	Task { await store.snooze(event.id, until: duration.date(from: .now)) }	319	Task { await store.snooze(event.id, until: duration.date(from: .now)) }

octosentry/SecurityEventRow.swift +9 −6

     var attribution: String?
     var isHidden = false
     var snoozedUntil: Date?
-    var onMarkSeen: () -> Void
+    var onToggleSeen: () -> Void
     var onDismiss: () -> Void = {}
     var onSnooze: (SnoozeDuration) -> Void = { _ in }
     var onRestore: () -> Void = {}
                 }
                 .padding(10)
                 .contentShape(Rectangle())
+                // Seen alerts stay in the feed but recede, so the
+                // acknowledgement is visible rather than silently discarded.
+                .opacity(event.seenLocally ? 0.5 : 1)
             }
             .buttonStyle(.plain)
                 .padding(.top, 12)
                 .padding(.trailing, 10)
             } else {
-                Button(action: onMarkSeen) {
+                Button(action: onToggleSeen) {
-                    Image(systemName: "checkmark.circle")
+                    Image(systemName: event.seenLocally ? "checkmark.circle.fill" : "checkmark.circle")
                 }
                 .buttonStyle(.plain)
-                .foregroundStyle(.secondary)
+                .foregroundStyle(event.seenLocally ? Color.accentColor : .secondary)
-                .help("Mark as seen")
+                .help(event.seenLocally ? "Mark as unseen" : "Mark as seen")
                 .padding(.top, 12)
                 .padding(.trailing, 6)
             updatedAt: .now,
             seenLocally: false
         ),
-        onMarkSeen: {}
+        onToggleSeen: {}
     )
 }

octosentry/SecurityEventStore.swift +13 −4

     /// Local-only triage state (spec §11) — no API write, no scope beyond
     /// read needed. Removes the event from the active stream.
-    func markSeen(_ eventID: String) async {
+    /// Acknowledges an alert without hiding it — the row stays, rendered as
+    /// seen. Dropping it from the feed only lasted until the next poll put it
+    /// back looking untouched; hiding an alert is what dismiss and snooze are
+    /// for. Toggleable, so acknowledging isn't a one-way door.
+    func setSeen(_ eventID: String, _ seen: Bool) async {
         var state = await persistenceStore.load()
-        state.seenEventIDs.insert(eventID)
+        if seen {
+            state.seenEventIDs.insert(eventID)
+        } else {
+            state.seenEventIDs.remove(eventID)
+        }
         await persistenceStore.save(state)
-        rawEvents.removeAll { $0.id == eventID }
+        if let index = rawEvents.firstIndex(where: { $0.id == eventID }) {
-        totalFetchedCount = rawEvents.count
+            rawEvents[index].seenLocally = seen
+        }
         applyFilters()
     }

Commit 0dca8dc832

Commit `0dca8dc832`