Commit `9cd7a260bd`

9cd7a260bdd158939c5d11f7d99a63f337915fb3

parent: a9bc9a9685

Unsigned

cmc <hello@cleberg.net> · 2026-08-31 17:30 UTC

Drop Sendable from OrgHTMLTreeRenderer

It stores a CodeHighlighter, which a real implementation backs with a
thread-confined engine, so the conformance claimed a safety the type does
not have. Nothing held one across an isolation boundary. Warning-free
under strict concurrency now.

Layout: unified · split

Sources/OrgSwift/AST/OrgHTMLTreeRenderer.swift +5 −1

 /// The point of the prototype: this produces the same shape of output as the shipped
 /// single-pass ``OrgRenderer``, but from a parsed tree rather than from source, so a second
 /// renderer (see ``OrgAttributedStringRenderer``) can share the parse instead of re-deriving it.
-public struct OrgHTMLTreeRenderer: Sendable {
+///
+/// Not `Sendable`: it holds a ``CodeHighlighter``, and a real one wraps a thread-confined
+/// engine (Highlightr's JavaScriptCore context, say). Sending the renderer across isolation
+/// domains would call that engine off its thread. Make one where you render.
+public struct OrgHTMLTreeRenderer {
     /// The same options the shipped ``OrgRenderer`` takes, so this renderer is a drop-in for it.
     public var options: OrgRenderOptions
     public var highlighter: CodeHighlighter

Commit 9cd7a260bd

Commit `9cd7a260bd`