internal/store/labels_test.go
206 lines · 6408 bytes
1package store
2
3import (
4 "errors"
5 "testing"
6)
7
8// acmeFixture: org acme owned by alice with repos acme/core and
9// acme/site, an issue in each, and alice's own alice/app.
10type acmeFixture struct {
11 s *Store
12 alice int64
13 org int64
14 core, site Repo
15 app Repo
16 coreIssue int64
17 siteIssue int64
18}
19
20func newAcme(t *testing.T) acmeFixture {
21 t.Helper()
22 s := open(t)
23 if err := s.MigrateUp(); err != nil {
24 t.Fatal(err)
25 }
26 var f acmeFixture
27 f.s = s
28 var err error
29 if f.alice, err = s.CreateUser("alice", false); err != nil {
30 t.Fatal(err)
31 }
32 if f.org, err = s.CreateOrg("acme", f.alice); err != nil {
33 t.Fatal(err)
34 }
35 mk := func(kind string, owner int64, name string) Repo {
36 id, err := s.CreateRepo(kind, owner, name, "public")
37 if err != nil {
38 t.Fatal(err)
39 }
40 r, err := s.RepoByID(id)
41 if err != nil {
42 t.Fatal(err)
43 }
44 return r
45 }
46 f.core = mk("org", f.org, "core")
47 f.site = mk("org", f.org, "site")
48 f.app = mk("user", f.alice, "app")
49 // CreateIssue returns the per-repo issue number, not the issues.id row
50 // that issue_labels.issue_id references (and that every production
51 // caller of SetIssueLabel passes); resolve it the same way they do, or
52 // core's and site's both-numbered-1 first issues collide.
53 mkIssue := func(repo Repo, title string) int64 {
54 n, err := s.CreateIssue(repo.ID, f.alice, title, "", "md")
55 if err != nil {
56 t.Fatal(err)
57 }
58 iss, err := s.IssueByNumber(repo.ID, n)
59 if err != nil {
60 t.Fatal(err)
61 }
62 return iss.ID
63 }
64 f.coreIssue = mkIssue(f.core, "c1")
65 f.siteIssue = mkIssue(f.site, "s1")
66 return f
67}
68
69func (f acmeFixture) orgRepos() []int64 { return []int64{f.core.ID, f.site.ID} }
70
71func TestOrgLabelSeenByEveryOrgRepo(t *testing.T) {
72 f := newAcme(t)
73 if _, err := f.s.SetOrgLabel(f.org, "bug", "#ff0000"); err != nil {
74 t.Fatal(err)
75 }
76 if err := f.s.SetLabel(f.site, "docs", ""); err != nil {
77 t.Fatal(err)
78 }
79 // site sees the org's bug first, then its own docs; core sees only bug;
80 // alice/app, user-owned, sees nothing.
81 got, err := f.s.ListLabels(f.site, f.orgRepos())
82 if err != nil || len(got) != 2 || got[0].Name != "bug" || !got[0].Org || got[1].Name != "docs" || got[1].Org {
83 t.Fatalf("site labels = %+v, %v", got, err)
84 }
85 if got, _ := f.s.ListLabels(f.core, f.orgRepos()); len(got) != 1 || got[0].Name != "bug" {
86 t.Fatalf("core labels = %+v", got)
87 }
88 if got, _ := f.s.ListLabels(f.app, []int64{f.app.ID}); len(got) != 0 {
89 t.Fatalf("app labels = %+v", got)
90 }
91 colors, _ := f.s.LabelColors(f.core)
92 if colors["bug"] != "#ff0000" {
93 t.Fatalf("core colours = %v", colors)
94 }
95}
96
97func TestIssueLabelResolvesOrgRowFirst(t *testing.T) {
98 f := newAcme(t)
99 if _, err := f.s.SetOrgLabel(f.org, "bug", ""); err != nil {
100 t.Fatal(err)
101 }
102 if err := f.s.SetIssueLabel(f.core, f.coreIssue, "bug", true); err != nil {
103 t.Fatal(err)
104 }
105 if err := f.s.SetIssueLabel(f.site, f.siteIssue, "bug", true); err != nil {
106 t.Fatal(err)
107 }
108 // One org row, no repo rows were created on the fly.
109 var n int
110 f.s.DB.QueryRow("SELECT COUNT(*) FROM labels WHERE name = 'bug'").Scan(&n)
111 if n != 1 {
112 t.Fatalf("labels named bug: %d, want 1", n)
113 }
114 // The count spans the org's readable repos.
115 got, _ := f.s.ListOrgLabels(f.org, f.orgRepos())
116 if len(got) != 1 || got[0].Issues != 2 {
117 t.Fatalf("org labels = %+v", got)
118 }
119 got, _ = f.s.ListOrgLabels(f.org, []int64{f.core.ID})
120 if got[0].Issues != 1 {
121 t.Fatalf("org labels over core only = %+v", got)
122 }
123 // A label neither scope has is still created on the fly in the repo.
124 if err := f.s.SetIssueLabel(f.core, f.coreIssue, "adhoc", true); err != nil {
125 t.Fatal(err)
126 }
127 if l, err := f.s.LabelByName(f.core, "adhoc"); err != nil || l.Org {
128 t.Fatalf("adhoc = %+v, %v", l, err)
129 }
130 // Removing by name works for the org row too.
131 if err := f.s.SetIssueLabel(f.core, f.coreIssue, "bug", false); err != nil {
132 t.Fatal(err)
133 }
134 got, _ = f.s.ListOrgLabels(f.org, f.orgRepos())
135 if got[0].Issues != 1 {
136 t.Fatalf("after detach: %+v", got)
137 }
138}
139
140func TestRepoLabelRefusedWhenOrgHoldsName(t *testing.T) {
141 f := newAcme(t)
142 if _, err := f.s.SetOrgLabel(f.org, "bug", ""); err != nil {
143 t.Fatal(err)
144 }
145 if err := f.s.SetLabel(f.core, "bug", "#00ff00"); !errors.Is(err, ErrOrgScoped) {
146 t.Fatalf("SetLabel over org name: %v, want ErrOrgScoped", err)
147 }
148 if err := f.s.DeleteLabel(f.core, "bug"); !errors.Is(err, ErrOrgScoped) {
149 t.Fatalf("DeleteLabel of org row: %v, want ErrOrgScoped", err)
150 }
151 if err := f.s.DeleteLabel(f.core, "nope"); !errors.Is(err, ErrNotFound) {
152 t.Fatalf("DeleteLabel of nothing: %v, want ErrNotFound", err)
153 }
154 // A user-owned repo is unaffected by any org.
155 if err := f.s.SetLabel(f.app, "bug", ""); err != nil {
156 t.Fatal(err)
157 }
158}
159
160func TestSetOrgLabelPromotesRepoLabels(t *testing.T) {
161 f := newAcme(t)
162 if err := f.s.SetIssueLabel(f.core, f.coreIssue, "bug", true); err != nil {
163 t.Fatal(err)
164 }
165 if err := f.s.SetIssueLabel(f.site, f.siteIssue, "bug", true); err != nil {
166 t.Fatal(err)
167 }
168 if err := f.s.SetLabel(f.app, "bug", "#123456"); err != nil {
169 t.Fatal(err)
170 }
171 folded, err := f.s.SetOrgLabel(f.org, "bug", "#ff0000")
172 if err != nil || folded != 2 {
173 t.Fatalf("SetOrgLabel folded %d, %v; want 2", folded, err)
174 }
175 var n int
176 f.s.DB.QueryRow("SELECT COUNT(*) FROM labels WHERE name = 'bug' AND org_id = ?", f.org).Scan(&n)
177 if n != 1 {
178 t.Fatalf("org rows named bug: %d", n)
179 }
180 f.s.DB.QueryRow("SELECT COUNT(*) FROM labels WHERE name = 'bug' AND repo_id IN (?, ?)", f.core.ID, f.site.ID).Scan(&n)
181 if n != 0 {
182 t.Fatalf("repo rows named bug left under the org: %d", n)
183 }
184 got, _ := f.s.ListOrgLabels(f.org, f.orgRepos())
185 if len(got) != 1 || got[0].Issues != 2 || got[0].Color != "#ff0000" {
186 t.Fatalf("after promote: %+v", got)
187 }
188 // alice/app's own bug is another owner's and stays.
189 if l, err := f.s.LabelByName(f.app, "bug"); err != nil || l.Color != "#123456" {
190 t.Fatalf("app bug = %+v, %v", l, err)
191 }
192 // A second set only recolours.
193 if folded, err := f.s.SetOrgLabel(f.org, "bug", "#0000ff"); err != nil || folded != 0 {
194 t.Fatalf("second set folded %d, %v", folded, err)
195 }
196 if err := f.s.DeleteOrgLabel(f.org, "bug"); err != nil {
197 t.Fatal(err)
198 }
199 if err := f.s.DeleteOrgLabel(f.org, "bug"); !errors.Is(err, ErrNotFound) {
200 t.Fatalf("second delete: %v", err)
201 }
202 f.s.DB.QueryRow("SELECT COUNT(*) FROM issue_labels").Scan(&n)
203 if n != 0 {
204 t.Fatalf("memberships after org delete: %d", n)
205 }
206}