krz/gitbay

A CLI-first git forge. cli forge git self-hosted https://gitbay.org

Commit 7d1aad238f

7d1aad238ffa3ecd2e98e9c7bb97cd20feab69e4

parent: 539835bd23

Verified · cmc ci/build: success ci/test: success

cmc <hello@cleberg.net> · 2026-09-28 23:06 UTC 

tests: newer callers pass a nil pack limiter to New

Ref #262

Layout: unified · split

internal/httpd/account_test.go +2 −2
@@ -212,7 +212,7 @@ func TestPinToggleDispatchesRepoPin(t *testing.T) {
212 t.Fatal(err) 212 t.Fatal(err)
213 } 213 }
214 214
215 s := New(config.Default(), st) 215 s := New(config.Default(), st, nil)
216 req := httptest.NewRequest("POST", "/alice/app/pin", nil) 216 req := httptest.NewRequest("POST", "/alice/app/pin", nil)
217 req.SetPathValue("owner", "alice") 217 req.SetPathValue("owner", "alice")
218 req.SetPathValue("repo", "app") 218 req.SetPathValue("repo", "app")
@@ -261,7 +261,7 @@ func TestWatchToggleCyclesThroughMuted(t *testing.T) {
261 t.Fatal(err) 261 t.Fatal(err)
262 } 262 }
263 263
264 s := New(config.Default(), st) 264 s := New(config.Default(), st, nil)
265 req := httptest.NewRequest("POST", "/alice/app/watch", nil) 265 req := httptest.NewRequest("POST", "/alice/app/watch", nil)
266 req.SetPathValue("owner", "alice") 266 req.SetPathValue("owner", "alice")
267 req.SetPathValue("repo", "app") 267 req.SetPathValue("repo", "app")
internal/httpd/issuecreate_test.go +5 −5
@@ -79,7 +79,7 @@ func TestIssueCreateFormHasMilestoneAndAssigneeForWriter(t *testing.T) {
79 79
80 cfg := config.Default() 80 cfg := config.Default()
81 cfg.Web.Mode = "accounts" 81 cfg.Web.Mode = "accounts"
82 s := New(cfg, st) 82 s := New(cfg, st, nil)
83 req := httptest.NewRequest("GET", "/alice/app/issues/new", nil) 83 req := httptest.NewRequest("GET", "/alice/app/issues/new", nil)
84 req.SetPathValue("owner", "alice") 84 req.SetPathValue("owner", "alice")
85 req.SetPathValue("repo", "app") 85 req.SetPathValue("repo", "app")
@@ -125,7 +125,7 @@ func TestIssueCreateFormHidesMilestoneAndAssigneeForReader(t *testing.T) {
125 125
126 cfg := config.Default() 126 cfg := config.Default()
127 cfg.Web.Mode = "accounts" 127 cfg.Web.Mode = "accounts"
128 s := New(cfg, st) 128 s := New(cfg, st, nil)
129 req := httptest.NewRequest("GET", "/alice/app/issues/new", nil) 129 req := httptest.NewRequest("GET", "/alice/app/issues/new", nil)
130 req.SetPathValue("owner", "alice") 130 req.SetPathValue("owner", "alice")
131 req.SetPathValue("repo", "app") 131 req.SetPathValue("repo", "app")
@@ -198,7 +198,7 @@ func TestIssueCreateSubmitReaderLabelIsDropped(t *testing.T) {
198 t.Fatal(err) 198 t.Fatal(err)
199 } 199 }
200 200
201 s := New(config.Default(), st) 201 s := New(config.Default(), st, nil)
202 form := url.Values{ 202 form := url.Values{
203 "title": {"a bug"}, 203 "title": {"a bug"},
204 "body": {"steps"}, 204 "body": {"steps"},
@@ -254,7 +254,7 @@ func TestIssueCreateSubmitSetsMilestoneAndAssignee(t *testing.T) {
254 t.Fatal(err) 254 t.Fatal(err)
255 } 255 }
256 256
257 s := New(config.Default(), st) 257 s := New(config.Default(), st, nil)
258 form := url.Values{ 258 form := url.Values{
259 "title": {"needs a fix"}, 259 "title": {"needs a fix"},
260 "body": {"details"}, 260 "body": {"details"},
@@ -308,7 +308,7 @@ func TestIssueCreateSubmitBadAssigneeCreatesNothing(t *testing.T) {
308 t.Fatal(err) 308 t.Fatal(err)
309 } 309 }
310 310
311 s := New(config.Default(), st) 311 s := New(config.Default(), st, nil)
312 form := url.Values{ 312 form := url.Values{
313 "title": {"needs a fix"}, 313 "title": {"needs a fix"},
314 "body": {"details"}, 314 "body": {"details"},
internal/httpd/logincookie_test.go +1 −1
@@ -52,7 +52,7 @@ func TestLoginNoStoreHeader(t *testing.T) {
52 if err := st.MigrateUp(); err != nil { 52 if err := st.MigrateUp(); err != nil {
53 t.Fatal(err) 53 t.Fatal(err)
54 } 54 }
55 s := New(config.Default(), st) 55 s := New(config.Default(), st, nil)
56 rr := httptest.NewRecorder() 56 rr := httptest.NewRecorder()
57 req := httptest.NewRequest("GET", "/login?token=bogus", nil) 57 req := httptest.NewRequest("GET", "/login?token=bogus", nil)
58 s.login(rr, req) 58 s.login(rr, req)
internal/httpd/mrrangediff_test.go +3 −3
@@ -36,7 +36,7 @@ func TestMRRangeDiffPageRendersCommandOutput(t *testing.T) {
36 t.Fatal(err) 36 t.Fatal(err)
37 } 37 }
38 38
39 s := New(config.Default(), st) 39 s := New(config.Default(), st, nil)
40 req := httptest.NewRequest("GET", "/alice/app/mrs/1/range-diff", nil) 40 req := httptest.NewRequest("GET", "/alice/app/mrs/1/range-diff", nil)
41 req.SetPathValue("owner", "alice") 41 req.SetPathValue("owner", "alice")
42 req.SetPathValue("repo", "app") 42 req.SetPathValue("repo", "app")
@@ -180,7 +180,7 @@ func loginCookie(t *testing.T, st *store.Store, userID int64) *http.Cookie {
180// user with no access (#269). 180// user with no access (#269).
181func TestMRRangeDiffPagePrivateRepo(t *testing.T) { 181func TestMRRangeDiffPagePrivateRepo(t *testing.T) {
182 st, cfg, alice, bob, repo, n, _, _, title := rangeDiffFixture(t) 182 st, cfg, alice, bob, repo, n, _, _, title := rangeDiffFixture(t)
183 s := New(cfg, st) 183 s := New(cfg, st, nil)
184 184
185 newReq := func(cookie *http.Cookie) (*httptest.ResponseRecorder, *http.Request) { 185 newReq := func(cookie *http.Cookie) (*httptest.ResponseRecorder, *http.Request) {
186 req := httptest.NewRequest("GET", "/alice/secret/mrs/"+strconv.FormatInt(n, 10)+"/range-diff", nil) 186 req := httptest.NewRequest("GET", "/alice/secret/mrs/"+strconv.FormatInt(n, 10)+"/range-diff", nil)
@@ -232,7 +232,7 @@ func TestMRRangeDiffPagePrivateRepo(t *testing.T) {
232// range-diff between exactly those two. 232// range-diff between exactly those two.
233func TestMRRangeDiffPageFromToQuery(t *testing.T) { 233func TestMRRangeDiffPageFromToQuery(t *testing.T) {
234 st, cfg, alice, _, repo, n, v1, v2, _ := rangeDiffFixture(t) 234 st, cfg, alice, _, repo, n, v1, v2, _ := rangeDiffFixture(t)
235 s := New(cfg, st) 235 s := New(cfg, st, nil)
236 cookie := loginCookie(t, st, alice.ID) 236 cookie := loginCookie(t, st, alice.ID)
237 237
238 newReq := func(query string) (*httptest.ResponseRecorder, *http.Request) { 238 newReq := func(query string) (*httptest.ResponseRecorder, *http.Request) {
internal/httpd/mrslist_test.go +1 −1
@@ -37,7 +37,7 @@ func TestMRsListContributionHintByAccess(t *testing.T) {
37 37
38 cfg := config.Default() 38 cfg := config.Default()
39 cfg.Web.Mode = "accounts" 39 cfg.Web.Mode = "accounts"
40 s := New(cfg, st) 40 s := New(cfg, st, nil)
41 41
42 // mrs reads the viewer through s.viewer(r), which resolves a 42 // mrs reads the viewer through s.viewer(r), which resolves a
43 // session cookie (internal/httpd/accounts.go:37-47) rather than 43 // session cookie (internal/httpd/accounts.go:37-47) rather than
internal/sshd/sshd_test.go +1 −1
@@ -245,7 +245,7 @@ func TestUnregisteredKeyMessageNamesFingerprintAndHost(t *testing.T) {
245 // The settings link keeps the site URL's scheme and port. 245 // The settings link keeps the site URL's scheme and port.
246 cfg.Server.SiteURL = "http://forge.test:8080/" 246 cfg.Server.SiteURL = "http://forge.test:8080/"
247 cfg.Registration.Mode = "open" 247 cfg.Registration.Mode = "open"
248 srv, err := New(cfg, st) 248 srv, err := New(cfg, st, nil)
249 if err != nil { 249 if err != nil {
250 t.Fatal(err) 250 t.Fatal(err)
251 } 251 }