Commit 7d1aad238f
7d1aad238ffa3ecd2e98e9c7bb97cd20feab69e4
parent: 539835bd23
Verified · cmc ci/build: success ci/test: success
cmc <hello@cleberg.net> · 2026-09-28 23:06 UTC
tests: newer callers pass a nil pack limiter to New
Ref #262
Layout: unified · split
internal/httpd/account_test.go
+2 −2
| @@ -212,7 +212,7 @@ func TestPinToggleDispatchesRepoPin(t *testing.T) { |
| 212 | 212 | t.Fatal(err) |
| 213 | 213 | } |
| 214 | 214 | |
| 215 | | s := New(config.Default(), st) |
| 215 | s := New(config.Default(), st, nil) |
| 216 | 216 | req := httptest.NewRequest("POST", "/alice/app/pin", nil) |
| 217 | 217 | req.SetPathValue("owner", "alice") |
| 218 | 218 | req.SetPathValue("repo", "app") |
| @@ -261,7 +261,7 @@ func TestWatchToggleCyclesThroughMuted(t *testing.T) { |
| 261 | 261 | t.Fatal(err) |
| 262 | 262 | } |
| 263 | 263 | |
| 264 | | s := New(config.Default(), st) |
| 264 | s := New(config.Default(), st, nil) |
| 265 | 265 | req := httptest.NewRequest("POST", "/alice/app/watch", nil) |
| 266 | 266 | req.SetPathValue("owner", "alice") |
| 267 | 267 | req.SetPathValue("repo", "app") |
internal/httpd/issuecreate_test.go
+5 −5
| @@ -79,7 +79,7 @@ func TestIssueCreateFormHasMilestoneAndAssigneeForWriter(t *testing.T) { |
| 79 | 79 | |
| 80 | 80 | cfg := config.Default() |
| 81 | 81 | cfg.Web.Mode = "accounts" |
| 82 | | s := New(cfg, st) |
| 82 | s := New(cfg, st, nil) |
| 83 | 83 | req := httptest.NewRequest("GET", "/alice/app/issues/new", nil) |
| 84 | 84 | req.SetPathValue("owner", "alice") |
| 85 | 85 | req.SetPathValue("repo", "app") |
| @@ -125,7 +125,7 @@ func TestIssueCreateFormHidesMilestoneAndAssigneeForReader(t *testing.T) { |
| 125 | 125 | |
| 126 | 126 | cfg := config.Default() |
| 127 | 127 | cfg.Web.Mode = "accounts" |
| 128 | | s := New(cfg, st) |
| 128 | s := New(cfg, st, nil) |
| 129 | 129 | req := httptest.NewRequest("GET", "/alice/app/issues/new", nil) |
| 130 | 130 | req.SetPathValue("owner", "alice") |
| 131 | 131 | req.SetPathValue("repo", "app") |
| @@ -198,7 +198,7 @@ func TestIssueCreateSubmitReaderLabelIsDropped(t *testing.T) { |
| 198 | 198 | t.Fatal(err) |
| 199 | 199 | } |
| 200 | 200 | |
| 201 | | s := New(config.Default(), st) |
| 201 | s := New(config.Default(), st, nil) |
| 202 | 202 | form := url.Values{ |
| 203 | 203 | "title": {"a bug"}, |
| 204 | 204 | "body": {"steps"}, |
| @@ -254,7 +254,7 @@ func TestIssueCreateSubmitSetsMilestoneAndAssignee(t *testing.T) { |
| 254 | 254 | t.Fatal(err) |
| 255 | 255 | } |
| 256 | 256 | |
| 257 | | s := New(config.Default(), st) |
| 257 | s := New(config.Default(), st, nil) |
| 258 | 258 | form := url.Values{ |
| 259 | 259 | "title": {"needs a fix"}, |
| 260 | 260 | "body": {"details"}, |
| @@ -308,7 +308,7 @@ func TestIssueCreateSubmitBadAssigneeCreatesNothing(t *testing.T) { |
| 308 | 308 | t.Fatal(err) |
| 309 | 309 | } |
| 310 | 310 | |
| 311 | | s := New(config.Default(), st) |
| 311 | s := New(config.Default(), st, nil) |
| 312 | 312 | form := url.Values{ |
| 313 | 313 | "title": {"needs a fix"}, |
| 314 | 314 | "body": {"details"}, |
internal/httpd/logincookie_test.go
+1 −1
| @@ -52,7 +52,7 @@ func TestLoginNoStoreHeader(t *testing.T) { |
| 52 | 52 | if err := st.MigrateUp(); err != nil { |
| 53 | 53 | t.Fatal(err) |
| 54 | 54 | } |
| 55 | | s := New(config.Default(), st) |
| 55 | s := New(config.Default(), st, nil) |
| 56 | 56 | rr := httptest.NewRecorder() |
| 57 | 57 | req := httptest.NewRequest("GET", "/login?token=bogus", nil) |
| 58 | 58 | s.login(rr, req) |
internal/httpd/mrrangediff_test.go
+3 −3
| @@ -36,7 +36,7 @@ func TestMRRangeDiffPageRendersCommandOutput(t *testing.T) { |
| 36 | 36 | t.Fatal(err) |
| 37 | 37 | } |
| 38 | 38 | |
| 39 | | s := New(config.Default(), st) |
| 39 | s := New(config.Default(), st, nil) |
| 40 | 40 | req := httptest.NewRequest("GET", "/alice/app/mrs/1/range-diff", nil) |
| 41 | 41 | req.SetPathValue("owner", "alice") |
| 42 | 42 | req.SetPathValue("repo", "app") |
| @@ -180,7 +180,7 @@ func loginCookie(t *testing.T, st *store.Store, userID int64) *http.Cookie { |
| 180 | 180 | // user with no access (#269). |
| 181 | 181 | func TestMRRangeDiffPagePrivateRepo(t *testing.T) { |
| 182 | 182 | st, cfg, alice, bob, repo, n, _, _, title := rangeDiffFixture(t) |
| 183 | | s := New(cfg, st) |
| 183 | s := New(cfg, st, nil) |
| 184 | 184 | |
| 185 | 185 | newReq := func(cookie *http.Cookie) (*httptest.ResponseRecorder, *http.Request) { |
| 186 | 186 | req := httptest.NewRequest("GET", "/alice/secret/mrs/"+strconv.FormatInt(n, 10)+"/range-diff", nil) |
| @@ -232,7 +232,7 @@ func TestMRRangeDiffPagePrivateRepo(t *testing.T) { |
| 232 | 232 | // range-diff between exactly those two. |
| 233 | 233 | func TestMRRangeDiffPageFromToQuery(t *testing.T) { |
| 234 | 234 | st, cfg, alice, _, repo, n, v1, v2, _ := rangeDiffFixture(t) |
| 235 | | s := New(cfg, st) |
| 235 | s := New(cfg, st, nil) |
| 236 | 236 | cookie := loginCookie(t, st, alice.ID) |
| 237 | 237 | |
| 238 | 238 | newReq := func(query string) (*httptest.ResponseRecorder, *http.Request) { |
internal/httpd/mrslist_test.go
+1 −1
| @@ -37,7 +37,7 @@ func TestMRsListContributionHintByAccess(t *testing.T) { |
| 37 | 37 | |
| 38 | 38 | cfg := config.Default() |
| 39 | 39 | cfg.Web.Mode = "accounts" |
| 40 | | s := New(cfg, st) |
| 40 | s := New(cfg, st, nil) |
| 41 | 41 | |
| 42 | 42 | // mrs reads the viewer through s.viewer(r), which resolves a |
| 43 | 43 | // session cookie (internal/httpd/accounts.go:37-47) rather than |
internal/sshd/sshd_test.go
+1 −1
| @@ -245,7 +245,7 @@ func TestUnregisteredKeyMessageNamesFingerprintAndHost(t *testing.T) { |
| 245 | 245 | // The settings link keeps the site URL's scheme and port. |
| 246 | 246 | cfg.Server.SiteURL = "http://forge.test:8080/" |
| 247 | 247 | cfg.Registration.Mode = "open" |
| 248 | | srv, err := New(cfg, st) |
| 248 | srv, err := New(cfg, st, nil) |
| 249 | 249 | if err != nil { |
| 250 | 250 | t.Fatal(err) |
| 251 | 251 | } |