Commit `9025627391`

90256273913c400c5603be82427e9321416ec8d8

Unsigned

cmc <hello@cleberg.net> · 2026-04-03 20:47 UTC

chore: add explanatory comments to all intentional empty closures

Layout: unified · split

Hutch/Views/Repositories/FileTreeView.swift +6 −2

             FileContentShareSheet(activityItems: [text])
         }
         .alert("Share Unavailable", isPresented: $showShareUnavailableAlert) {
-            Button("OK", role: .cancel) {}
+            Button("OK", role: .cancel) {
+                // no-op: .cancel role handles alert dismissal
+            }
         } message: {
             Text(SRHTShareTarget.file.fallbackMessage)
         }
         UIActivityViewController(activityItems: activityItems, applicationActivities: nil)
     }
-    func updateUIViewController(_ : UIActivityViewController, context _: Context) {}
+    func updateUIViewController(_ : UIActivityViewController, context _: Context) {
+        // no-op: UIActivityViewController manages its own state after presentation
+    }
 }
 final class CodeFileUIView: UIView {

Hutch/Views/Repositories/HgRepositoryDetailView.swift +3 −1

                     FileContentShareSheet(activityItems: [shareURL ?? fileContent])
                 }
                 .alert("Share Unavailable", isPresented: $showShareUnavailableAlert) {
-                    Button("OK", role: .cancel) {}
+                    Button("OK", role: .cancel) {
+                        // no-op: .cancel role handles alert dismissal
+                    }
                 } message: {
                     Text(SRHTShareTarget.file.fallbackMessage)
                 }

Hutch/Views/Tickets/TicketListView.swift +5 −3

     init(
         tracker: TrackerSummary,
-        onTrackerUpdated: @escaping (TrackerSummary) -> Void = { _ in },
+        onTrackerUpdated: @escaping (TrackerSummary) -> Void = { _ in /* no-op: default for callers that don't handle this event */ },
-        onTrackerDeleted: @escaping (TrackerSummary) -> Void = { _ in }
+        onTrackerDeleted: @escaping (TrackerSummary) -> Void = { _ in /* no-op: default for callers that don't handle this event */ }
     ) {
         self._tracker = State(initialValue: tracker)
         self.onTrackerUpdated = onTrackerUpdated
             }
         }
         .alert("Delete Tracker?", isPresented: $showDeleteTrackerConfirmation) {
-            Button("Cancel", role: .cancel) {}
+            Button("Cancel", role: .cancel) {
+                // no-op: .cancel role handles alert dismissal
+            }
             Button("Delete", role: .destructive) {
                 guard let trackerManagementViewModel else { return }
                 Task {

Hutch/Views/Tickets/TrackerListView.swift +3 −1

                 }
             }
         )) {
-            Button("Cancel", role: .cancel) {}
+            Button("Cancel", role: .cancel) {
+                // no-op: .cancel role handles alert dismissal
+            }
             Button("Delete", role: .destructive) {
                 guard let pendingDeletion, let viewModel else { return }
                 Task {

Hutch/Views/Tickets/TrackerManagementView.swift +6 −2

                     }
                 }
             )) {
-                Button("Cancel", role: .cancel) {}
+                Button("Cancel", role: .cancel) {
+                    // no-op: .cancel role handles alert dismissal
+                }
                 Button("Delete", role: .destructive) {
                     guard let pendingDeletion else { return }
                     Task {
                     }
                 }
             )) {
-                Button("Cancel", role: .cancel) {}
+                Button("Cancel", role: .cancel) {
+                    // no-op: .cancel role handles alert dismissal
+                }
                 Button("Delete", role: .destructive) {
                     guard let pendingDeletion else { return }
                     Task {

Commit 9025627391