Commit `9e6ec71086`

9e6ec710861994439ab9eb56949da4f7ffa512ff

parent: 8fc97b98ae

Unsigned

cmc <hello@cleberg.net> · 2026-04-13 18:26 UTC

perf: reduce redundant fetches and improve list render efficiency

- Remove no-op per-row task from RepositoryListView; loadMoreIfNeeded
  is a stub for repos so each row was allocating a Task that did nothing
- Fix BuildListView auto-refresh stopping permanently after navigating
  away; startAutoRefresh now runs unconditionally on task so it restarts
  on every reappear, not just first load
- Add lastRefreshed tracking to HomeViewModel with a needsRefresh(after:)
  helper; HomeView and WorkView scene-activation handlers now skip
  loadDashboard() if the data is less than 60 seconds old
- Add 120-second TTL to repository build status refresh; statuses are
  no longer re-fetched on every tab appear, only when stale or when the
  user explicitly pulls to refresh (forceRefresh: true)

Implements: https://todo.sr.ht/~ccleberg/hutch/56

Layout: unified · split

Hutch.xcodeproj/project.pbxproj +8 −8

	@@ -515,7 +515,7 @@
515	ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;	515	ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
516	CODE_SIGN_ENTITLEMENTS = Hutch/Hutch.entitlements;	516	CODE_SIGN_ENTITLEMENTS = Hutch/Hutch.entitlements;
517	CODE_SIGN_STYLE = Automatic;	517	CODE_SIGN_STYLE = Automatic;
518	CURRENT_PROJECT_VERSION = 60;	518	CURRENT_PROJECT_VERSION = 61;
519	DEVELOPMENT_TEAM = ZCNAX3VL9D;	519	DEVELOPMENT_TEAM = ZCNAX3VL9D;
520	ENABLE_PREVIEWS = YES;	520	ENABLE_PREVIEWS = YES;
521	GENERATE_INFOPLIST_FILE = YES;	521	GENERATE_INFOPLIST_FILE = YES;
	@@ -532,7 +532,7 @@
532	"$(inherited)",	532	"$(inherited)",
533	"@executable_path/Frameworks",	533	"@executable_path/Frameworks",
534	);	534	);
535	MARKETING_VERSION = 2.21.1;	535	MARKETING_VERSION = 3.0.0;
536	PRODUCT_BUNDLE_IDENTIFIER = net.cleberg.Hutch;	536	PRODUCT_BUNDLE_IDENTIFIER = net.cleberg.Hutch;
537	PRODUCT_NAME = "$(TARGET_NAME)";	537	PRODUCT_NAME = "$(TARGET_NAME)";
538	STRING_CATALOG_GENERATE_SYMBOLS = YES;	538	STRING_CATALOG_GENERATE_SYMBOLS = YES;
	@@ -552,7 +552,7 @@
552	ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;	552	ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
553	CODE_SIGN_ENTITLEMENTS = Hutch/Hutch.entitlements;	553	CODE_SIGN_ENTITLEMENTS = Hutch/Hutch.entitlements;
554	CODE_SIGN_STYLE = Automatic;	554	CODE_SIGN_STYLE = Automatic;
555	CURRENT_PROJECT_VERSION = 60;	555	CURRENT_PROJECT_VERSION = 61;
556	DEVELOPMENT_TEAM = ZCNAX3VL9D;	556	DEVELOPMENT_TEAM = ZCNAX3VL9D;
557	ENABLE_PREVIEWS = YES;	557	ENABLE_PREVIEWS = YES;
558	GENERATE_INFOPLIST_FILE = YES;	558	GENERATE_INFOPLIST_FILE = YES;
	@@ -569,7 +569,7 @@
569	"$(inherited)",	569	"$(inherited)",
570	"@executable_path/Frameworks",	570	"@executable_path/Frameworks",
571	);	571	);
572	MARKETING_VERSION = 2.21.1;	572	MARKETING_VERSION = 3.0.0;
573	PRODUCT_BUNDLE_IDENTIFIER = net.cleberg.Hutch;	573	PRODUCT_BUNDLE_IDENTIFIER = net.cleberg.Hutch;
574	PRODUCT_NAME = "$(TARGET_NAME)";	574	PRODUCT_NAME = "$(TARGET_NAME)";
575	STRING_CATALOG_GENERATE_SYMBOLS = YES;	575	STRING_CATALOG_GENERATE_SYMBOLS = YES;
	@@ -632,7 +632,7 @@
632	APPLICATION_EXTENSION_API_ONLY = YES;	632	APPLICATION_EXTENSION_API_ONLY = YES;
633	CODE_SIGN_ENTITLEMENTS = HutchWidgetExtension/HutchWidgetExtension.entitlements;	633	CODE_SIGN_ENTITLEMENTS = HutchWidgetExtension/HutchWidgetExtension.entitlements;
634	CODE_SIGN_STYLE = Automatic;	634	CODE_SIGN_STYLE = Automatic;
635	CURRENT_PROJECT_VERSION = 60;	635	CURRENT_PROJECT_VERSION = 61;
636	DEVELOPMENT_TEAM = ZCNAX3VL9D;	636	DEVELOPMENT_TEAM = ZCNAX3VL9D;
637	GENERATE_INFOPLIST_FILE = NO;	637	GENERATE_INFOPLIST_FILE = NO;
638	INFOPLIST_FILE = HutchWidgetExtension/Info.plist;	638	INFOPLIST_FILE = HutchWidgetExtension/Info.plist;
	@@ -642,7 +642,7 @@
642	"@executable_path/Frameworks",	642	"@executable_path/Frameworks",
643	"@executable_path/../../Frameworks",	643	"@executable_path/../../Frameworks",
644	);	644	);
645	MARKETING_VERSION = 2.21.1;	645	MARKETING_VERSION = 3.0.0;
646	PRODUCT_BUNDLE_IDENTIFIER = net.cleberg.Hutch.HutchWidgetExtension;	646	PRODUCT_BUNDLE_IDENTIFIER = net.cleberg.Hutch.HutchWidgetExtension;
647	PRODUCT_NAME = "$(TARGET_NAME)";	647	PRODUCT_NAME = "$(TARGET_NAME)";
648	SKIP_INSTALL = YES;	648	SKIP_INSTALL = YES;
	@@ -661,7 +661,7 @@
661	APPLICATION_EXTENSION_API_ONLY = YES;	661	APPLICATION_EXTENSION_API_ONLY = YES;
662	CODE_SIGN_ENTITLEMENTS = HutchWidgetExtension/HutchWidgetExtension.entitlements;	662	CODE_SIGN_ENTITLEMENTS = HutchWidgetExtension/HutchWidgetExtension.entitlements;
663	CODE_SIGN_STYLE = Automatic;	663	CODE_SIGN_STYLE = Automatic;
664	CURRENT_PROJECT_VERSION = 60;	664	CURRENT_PROJECT_VERSION = 61;
665	DEVELOPMENT_TEAM = ZCNAX3VL9D;	665	DEVELOPMENT_TEAM = ZCNAX3VL9D;
666	GENERATE_INFOPLIST_FILE = NO;	666	GENERATE_INFOPLIST_FILE = NO;
667	INFOPLIST_FILE = HutchWidgetExtension/Info.plist;	667	INFOPLIST_FILE = HutchWidgetExtension/Info.plist;
	@@ -671,7 +671,7 @@
671	"@executable_path/Frameworks",	671	"@executable_path/Frameworks",
672	"@executable_path/../../Frameworks",	672	"@executable_path/../../Frameworks",
673	);	673	);
674	MARKETING_VERSION = 2.21.1;	674	MARKETING_VERSION = 3.0.0;
675	PRODUCT_BUNDLE_IDENTIFIER = net.cleberg.Hutch.HutchWidgetExtension;	675	PRODUCT_BUNDLE_IDENTIFIER = net.cleberg.Hutch.HutchWidgetExtension;
676	PRODUCT_NAME = "$(TARGET_NAME)";	676	PRODUCT_NAME = "$(TARGET_NAME)";
677	SKIP_INSTALL = YES;	677	SKIP_INSTALL = YES;

Hutch/Views/Builds/BuildListView.swift +3 −1

                 vm.repoFilter = savedRepoFilter
                 viewModel = vm
                 await vm.loadJobs()
-                vm.startAutoRefresh(interval: autoRefreshInterval)
             }
+            // Restart auto-refresh every time the view (re)appears, since
+            // onDisappear stops it when navigating away.
+            viewModel?.startAutoRefresh(interval: autoRefreshInterval)
         }
         .onDisappear {
             viewModel?.stopAutoRefresh()

Hutch/Views/Home/HomeView.swift +1 −1

	@@ -48,7 +48,7 @@ struct HomeView: View {
48	loadRecentActivity()	48	loadRecentActivity()
49	}	49	}
50	.onChange(of: scenePhase) { _, newPhase in	50	.onChange(of: scenePhase) { _, newPhase in
51	guard newPhase == .active, let viewModel else { return }	51	guard newPhase == .active, let viewModel, viewModel.needsRefresh() else { return }
52	Task {	52	Task {
53	await viewModel.loadDashboard()	53	await viewModel.loadDashboard()
54	loadRecentActivity()	54	loadRecentActivity()

Hutch/Views/Home/HomeViewModel.swift +8

     private(set) var projectsError: String?
     private(set) var assignedTicketsError: String?
     private(set) var recentBuildsError: String?
+    private(set) var lastRefreshed: Date?
     private let currentUser: User
     private let client: SRHTClient
             systemStatusErrorMessage = error.userFacingMessage
         }
         isLoadingSystemStatus = false
+        lastRefreshed = Date()
         persistNeedsAttentionSnapshot()
         persistSystemStatusWidgetSnapshot()
     }
+    /// Returns true if sufficient time has elapsed since the last dashboard refresh.
+    func needsRefresh(after interval: TimeInterval = 60) -> Bool {
+        guard let lastRefreshed else { return true }
+        return Date().timeIntervalSince(lastRefreshed) > interval
+    }
     var hasDashboardContent: Bool {
         !pinnedProjects.isEmpty || !assignedTickets.isEmpty || !recentBuilds.isEmpty || !unreadInboxThreads.isEmpty || systemStatusSnapshot != nil
     }

Hutch/Views/Repositories/RepositoryListView.swift +1 −4

                     )
                 }
                 .alignmentGuide(.listRowSeparatorLeading) { _ in 0 }
-                .task {
-                    await viewModel.loadMoreIfNeeded(currentItem: repo)
-                }
             }
             if viewModel.isLoadingMore {
         }
         .srhtErrorBanner(error: $vm.error)
         .refreshable {
-            await viewModel.loadRepositories()
+            await viewModel.loadRepositories(forceRefresh: true)
         }
         .task {
             await viewModel.loadRepositories()

Hutch/Views/Repositories/RepositoryListViewModel.swift +12 −3

     private let client: SRHTClient
     private let defaults: UserDefaults
     private var buildStatusTask: Task<Void, Never>?
+    private var lastBuildStatusRefresh: Date?
     private static let gitCacheKey = "git.repositories"
     private static let hgCacheKey = "hg.repositories"
     /// Fetch the first page of repositories. Shows cached data instantly if available,
     /// then refreshes from the network in the background.
     /// - Parameter search: Optional search string. Pass `nil` to use the current `searchText`.
-    func loadRepositories(search: String? = nil) async {
+    /// - Parameter forceRefresh: When true, bypass the build-status TTL (e.g. pull-to-refresh).
+    func loadRepositories(search: String? = nil, forceRefresh: Bool = false) async {
         let query = (search ?? searchText).trimmingCharacters(in: .whitespacesAndNewlines)
         let isSearch = !query.isEmpty
             }
             repositories = filteredResults.sorted(by: repositorySortOrder)
-            scheduleBuildStatusRefresh()
+            scheduleBuildStatusRefresh(force: forceRefresh)
         } catch {
             // Only show error if we have no cached data to fall back on
             if repositories.isEmpty {
         }
     }
-    private func scheduleBuildStatusRefresh() {
+    private func scheduleBuildStatusRefresh(force: Bool = false) {
+        // Skip if we already refreshed recently (120-second TTL). Pull-to-refresh
+        // passes force: true to bypass this check.
+        if !force, let last = lastBuildStatusRefresh,
+           Date().timeIntervalSince(last) < 120 {
+            return
+        }
         let repositoriesSnapshot = repositories
         buildStatusTask?.cancel()
         buildStatusTask = Task { [weak self] in
             await MainActor.run {
                 guard repositories == self.repositories else { return }
                 latestBuildStatuses = finalStatuses
+                lastBuildStatusRefresh = Date()
             }
         } catch {
             // Build status is auxiliary data for the list. Leave the default gray state on failure.

Hutch/Views/Work/WorkView.swift +1 −1

	@@ -30,7 +30,7 @@ struct WorkView: View {
30	await ensureViewModel(currentUser: currentUser).loadDashboard()	30	await ensureViewModel(currentUser: currentUser).loadDashboard()
31	}	31	}
32	.onChange(of: scenePhase) { _, newPhase in	32	.onChange(of: scenePhase) { _, newPhase in
33	guard newPhase == .active, let viewModel else { return }	33	guard newPhase == .active, let viewModel, viewModel.needsRefresh() else { return }
34	Task {	34	Task {
35	await viewModel.loadDashboard()	35	await viewModel.loadDashboard()
36	}	36	}

Commit 9e6ec71086

Commit `9e6ec71086`