Commit `c47b1e6e6c`

c47b1e6e6cbff399dc7f5e60d2bae162e4cba511

parent: e6258f1dc1

Unsigned

cmc <hello@cleberg.net> · 2026-07-16 00:22 UTC

test: assert image URLs are not double-escaped

markdownImageQueryStringPreservesAmpersands rejected any "amp;metric" in the
rendered HTML, but `&amp;` is the correct encoding for `&` in an attribute
value and is what a browser needs to request a literal `&`. The assertion
conflated the URL with its HTML encoding.

Target the real failure mode instead: double-escaping, which would send
"&amp;" through as part of the query string and break badge images.

Layout: unified · split

HutchTests/ReadmeViewTests.swift +4 −1

     func markdownImageQueryStringPreservesAmpersands() {
         let html = processInline("![badge](https://sonarcloud.io/api/project_badges/measure?project=ccleberg_Hutch&metric=security_rating)")
+        // `&amp;` is the correct encoding for `&` in an attribute value, so the
+        // failure mode to guard against is double-escaping, which would make the
+        // browser request a literal "&amp;" in the query string.
         #expect(html.contains("metric=security_rating"))
-        #expect(!html.contains("amp;metric"))
+        #expect(!html.contains("&amp;amp;"))
         #expect(html.contains("<img"))
     }

Commit c47b1e6e6c

Commit `c47b1e6e6c`